Uh oh!
There was an error while loading. Please reload this page.
NLL is missing struct field suggestion - #54831
Merged
bors merged 2 commits intoOct 10, 2018
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
killercup
suggested changes
Oct 5, 2018
Uh oh!
There was an error while loading. Please reload this page.
davidtwcoforce-pushed
the
issue-52663-struct-field-suggestion
branch
from
October 5, 2018 12:49
e15c946 to
f0b457eComparekillercup
approved these changes
Oct 5, 2018
nikomatsakis
approved these changes
Oct 5, 2018
nikomatsakis
left a comment
Contributor
There was a problem hiding this comment.
r=me but maybe consider matching AST message (could we then remove the .nll reference?)
Uh oh!
There was an error while loading. Please reload this page.
pnkfelix
reviewed
Oct 8, 2018
Uh oh!
There was an error while loading. Please reload this page.
This commit adds suggestions to change the definitions of fields in struct definitions from immutable references to mutable references.
This commit changes the label to a maybe incorrect suggestion for better integration with RLS.
davidtwcoforce-pushed
the
issue-52663-struct-field-suggestion
branch
from
October 8, 2018 10:27
f0b457e to
9e49ac0Comparenikomatsakis
approved these changes
Oct 8, 2018
nikomatsakis
commented
Oct 8, 2018
Contributor
@bors r+ |
bors
commented
Oct 8, 2018
Collaborator
📌 Commit 9e49ac0 has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Oct 9, 2018
…suggestion, r=nikomatsakis NLL is missing struct field suggestion Part of rust-lang#52663. This commit adds suggestions to change the definitions of fields in struct definitions from immutable references to mutable references. r? @nikomatsakis cc @pnkfelix
bors
commented
Oct 10, 2018
Collaborator
bors added a commit
that referenced
this pull request
Oct 10, 2018
… r=nikomatsakis NLL is missing struct field suggestion Part of #52663. This commit adds suggestions to change the definitions of fields in struct definitions from immutable references to mutable references. r? @nikomatsakis cc @pnkfelix
bors
commented
Oct 10, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #52663.
This commit adds suggestions to change the definitions of fields in
struct definitions from immutable references to mutable references.
r? @nikomatsakis
cc @pnkfelix