Skip to content

Stabilize min_const_fn - #54835

Merged
bors merged 3 commits into
rust-lang:masterfrom
oli-obk:mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein
Oct 7, 2018

Hidden character warning

The head ref may contain hidden characters: "m\u00f6gen_konstante_funktionen_doch_bitte_endlich_stabil_sein"
Merged

Stabilize min_const_fn#54835
bors merged 3 commits into
rust-lang:masterfrom
oli-obk:mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein

Conversation

@oli-obk

Copy link
Copy Markdown
Contributor

tracking issue: #53555

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2018
@rust-highfive

This comment has been minimized.

@oli-obk
oli-obkforce-pushed the mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein branch from cfc51f0 to ec74d35CompareOctober 5, 2018 08:36
@rust-highfive

This comment has been minimized.

@killercup

Copy link
Copy Markdown
Contributor

You constantly surprise me, Oli: TIL git(hub) apparently works well with unicode branch names.

@Centril

Copy link
Copy Markdown
Contributor

Extra points for a great branch name =P

/me considers branch names in Swedish now

@CentrilCentril added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 5, 2018
@oli-obk

Copy link
Copy Markdown
ContributorAuthor

r? @RalfJung

The tracking issue has been FCPed and accepted for merging. @Centril already signed off.

@rust-highfiverust-highfive assigned RalfJung and unassigned CentrilOct 5, 2018
@oli-obk

Copy link
Copy Markdown
ContributorAuthor

Oh wait

@bors r=Centril

😈

@bors

bors commented Oct 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit fb04e26 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2018
@bors

bors commented Oct 7, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit fb04e26 with merge 0ee045e...

bors added a commit that referenced this pull request Oct 7, 2018
…endlich_stabil_sein, r=Centril
Stabilize `min_const_fn`
tracking issue: #53555
r? @Centril
@Centril

Copy link
Copy Markdown
Contributor

🙏

@bors

bors commented Oct 7, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: Centril
Pushing 0ee045e to master...

rubdos added a commit to rubdos/curve25519-dalek that referenced this pull request May 28, 2020
const_fn is stable since Rust 1.31
(rust-lang/rust#54835) and enables calling
`Scalar::from_bits(..)` from other const fn contexts, potentially
saving some overhead here and there.
Especially useful in contexts where constants are being built from a bit
pattern.
@oli-obk
oli-obk deleted the mögen_konstante_funktionen_doch_bitte_endlich_stabil_sein branch May 31, 2020 13:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@oli-obk@rust-highfive@killercup@Centril@bors@RalfJung