Skip to content

Remove unneccessary error from test, revealing NLL error. - #54853

Merged
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-52663-missing-lifetime-suggestion-test
Oct 6, 2018
Merged

Remove unneccessary error from test, revealing NLL error.#54853
bors merged 1 commit into
rust-lang:masterfrom
davidtwco:issue-52663-missing-lifetime-suggestion-test

Conversation

@davidtwco

Copy link
Copy Markdown
Member

Part of #52663.

Removes unnecessary type mismatch error from test that was hiding
borrow check error from NLL stderr.

r? @nikomatsakis

Removes unnecessary type mismatch error from test that was hiding
borrow check error from NLL stderr.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2018
@nikomatsakis

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 5, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit c07b712 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 5, 2018
…ime-suggestion-test, r=nikomatsakis
Remove unneccessary error from test, revealing NLL error.
Part of rust-lang#52663.
Removes unnecessary type mismatch error from test that was hiding
borrow check error from NLL stderr.
r? @nikomatsakis
bors added a commit that referenced this pull request Oct 6, 2018
Rollup of 11 pull requests
Successful merges:
- #54078 (Expand the documentation for the `std::sync` module)
- #54717 (Cleanup rustc/ty part 1)
- #54781 (Add examples to `TyKind::FnDef` and `TyKind::FnPtr` docs)
- #54787 (Only warn about unused `mut` in user-written code)
- #54804 (add suggestion for inverted function parameters)
- #54812 (Regression test for #32382.)
- #54833 (make `Parser::parse_foreign_item()` return a foreign item or error)
- #54834 (rustdoc: overflow:auto doesn't work nicely on small screens)
- #54838 (Fix typo in src/libsyntax/parse/parser.rs)
- #54851 (Fix a regression in 1.30 by reverting #53564)
- #54853 (Remove unneccessary error from test, revealing NLL error.)
Failed merges:
r? @ghost
@bors
bors merged commit c07b712 into rust-lang:masterOct 6, 2018
@pnkfelixpnkfelix added the A-NLL Area: Non-lexical lifetimes (NLL) label Oct 8, 2018
@davidtwco
davidtwco deleted the issue-52663-missing-lifetime-suggestion-test branch March 30, 2019 19:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-NLLArea: Non-lexical lifetimes (NLL)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidtwco@nikomatsakis@bors@pnkfelix@rust-highfive