Skip to content

[beta] Rollup backports - #54907

Merged
bors merged 8 commits into
rust-lang:betafrom
emilyalbini:beta-backports
Oct 9, 2018
Merged

[beta] Rollup backports#54907
bors merged 8 commits into
rust-lang:betafrom
emilyalbini:beta-backports

Conversation

@emilyalbini

@emilyalbiniemilyalbini commented Oct 8, 2018

Copy link
Copy Markdown
Member

Merged and approved:

r? @ghost

@emilyalbini

emilyalbini commented Oct 8, 2018

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=10

@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit ebca923 has been approved by pietroalbini

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 8, 2018
@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ebca923 with merge 26fd9f2cd58028e94f2866c1eecf27d0ca233ea8...

@borsbors mentioned this pull request Oct 8, 2018
Merged
@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2018
@emilyalbini

emilyalbini commented Oct 8, 2018

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2018
@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ebca923 with merge e47b13b...

bors added a commit that referenced this pull request Oct 8, 2018
@bors
Auto merge of#54907- pietroalbini:beta-backports, r=pietroalbini
e47b13b
[beta] Rollup backports
Merged and approved:
* #54851: Fix a regression in 1.30 by reverting #53564
* #54865: Backport 1.29.2 release notes to master
* #54810: Fix dead code lint for functions using impl Trait
r? @ghost
@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2018
@rust-highfive

rust-highfive commented Oct 8, 2018

Copy link
Copy Markdown
Contributor

The job i686-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:06:36] Memory: 8 GB
[00:06:36] Boot ROM Version: VMW71.00V.0.B64.1704110547
[00:06:36] Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:06:36] SMC Version (system): 2.8f0
[00:06:36] Serial Number (system): VMB6QhiLk1NM
[00:06:36] [00:06:36] hw.ncpu: 4
[00:06:36] hw.byteorder: 1234
[00:06:36] hw.memsize: 8589934592
---
[02:44:26] travis_time:end:stage0-linkchecker:start=1539035572930926000,finish=1539035577678976000,duration=4748050000
[02:44:26] [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "i686-apple-darwin" }, target: "i686-apple-darwin", tool: "linkchecker", path: "src/tools/linkchecker", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 4.749
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@emilyalbini

emilyalbini commented Oct 8, 2018

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2018
@bors

bors commented Oct 9, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ebca923 with merge e473232...

bors added a commit that referenced this pull request Oct 9, 2018
@bors
Auto merge of#54907- pietroalbini:beta-backports, r=pietroalbini
e473232
[beta] Rollup backports
Merged and approved:
* #54851: Fix a regression in 1.30 by reverting #53564
* #54865: Backport 1.29.2 release notes to master
* #54810: Fix dead code lint for functions using impl Trait
r? @ghost
@bors

bors commented Oct 9, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing e473232 to beta...

@bors
bors merged commit ebca923 into rust-lang:betaOct 9, 2018
@emilyalbini
emilyalbini deleted the beta-backports branch October 9, 2018 10:24
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@emilyalbini@bors@rust-highfive@Centril@alexcrichton@jonas-schievink