Skip to content

Unused result warning: "X which must" ↦ "X that must" - #54917

Merged
bors merged 1 commit into
rust-lang:masterfrom
varkor:unused-which
Oct 15, 2018
Merged

Unused result warning: "X which must" ↦ "X that must"#54917
bors merged 1 commit into
rust-lang:masterfrom
varkor:unused-which

Conversation

@varkor

Copy link
Copy Markdown
Contributor

Address a little grammatical faux pas in the unused result warning.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2018
@cramertj

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit dd0f5e5 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2018
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 9, 2018
Unused result warning: "X which must" ↦ "X that must"
Address a little grammatical faux pas in the unused result warning.
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 10, 2018
Unused result warning: "X which must" ↦ "X that must"
Address a little grammatical faux pas in the unused result warning.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 11, 2018
Unused result warning: "X which must" ↦ "X that must"
Address a little grammatical faux pas in the unused result warning.
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r-

Looks like this has killed a few rollups already (https://api.travis-ci.org/v3/job/440194173/log.txt)

[00:45:23] stderr:
[00:45:23] ------------------------------------------
[00:45:23] {"message":"unused return value of `foo` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":145,"byte_end":151,"line_start":14,"line_end":14,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":" foo(); //~ unused return value of `foo`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":33,"byte_end":48,"line_start":3,"line_end":3,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"#![deny(unused_must_use)]","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null}],"rendered":"error: unused return value of `foo` that must be used\n --> /checkout/src/test/ui/lint/must_use-unit.rs:14:5\n |\nLL | foo(); //~ unused return value of `foo`\n | ^^^^^^\n |\nnote: lint level defined here\n --> /checkout/src/test/ui/lint/must_use-unit.rs:3:9\n |\nLL | #![deny(unused_must_use)]\n | ^^^^^^^^^^^^^^^\n\n"}
[00:45:23] {"message":"unused return value of `bar` that must be used","code":{"code":"unused_must_use","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/lint/must_use-unit.rs","byte_start":190,"byte_end":196,"line_start":16,"line_end":16,"column_start":5,"column_end":11,"is_primary":true,"text":[{"text":" bar(); //~ unused return value of `bar`","highlight_start":5,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused return value of `bar` that must be used\n --> /checkout/src/test/ui/lint/must_use-unit.rs:16:5\n |\nLL | bar(); //~ unused return value of `bar`\n | ^^^^^^\n\n"}
[00:45:23] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[00:45:23] [00:45:23] ------------------------------------------
[00:45:23] 

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 11, 2018
@varkor

Copy link
Copy Markdown
ContributorAuthor

@Mark-Simulacrum: oh, whoops, this probably conflicts with #54920. I'll rebase after the rollup is merged. I should have pointed that out earlier, sorry!

@bors

bors commented Oct 13, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #55003) made this pull request unmergeable. Please resolve the merge conflicts.

@varkor

Copy link
Copy Markdown
ContributorAuthor

@bors r=cramertj rollup

@bors

bors commented Oct 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit f5b8906 has been approved by cramertj

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2018
@bors

bors commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f5b8906 with merge 4f9b581...

bors added a commit that referenced this pull request Oct 15, 2018
Unused result warning: "X which must" ↦ "X that must"
Address a little grammatical faux pas in the unused result warning.
@bors

bors commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 4f9b581 to master...

@bors
bors merged commit f5b8906 into rust-lang:masterOct 15, 2018
@varkor
varkor deleted the unused-which branch October 15, 2018 16:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@varkor@rust-highfive@cramertj@bors@Mark-Simulacrum@frewsxcv