Uh oh!
There was an error while loading. Please reload this page.
Cleanup the rest of codegen_llvm - #54933
Merged
Merged
Conversation
ljedrz
commented
Oct 9, 2018
ContributorAuthor
ljedrz
commented
Oct 16, 2018
ContributorAuthor
It seems @michaelwoerister might currently be unavailable; r? @varkor |
varkor
reviewed
Oct 16, 2018
varkor
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me apart from the semicolon nits.
| None => { /* generate one */} | ||
| }; | ||
| if let Some(unique_type_id) = self.type_to_unique_id.get(&type_).cloned() { | ||
| return unique_type_id |
Contributor
There was a problem hiding this comment.
return as part of a statement should end with a semicolon. (Here and in the other changes.)
ContributorAuthor
There was a problem hiding this comment.
I wasn't aware of that; thanks, I'll update the PR shortly.
| }, | ||
| _ => { /* safe to ignore */ } | ||
| if let FunctionDebugContext::RegularContext(ref data) = *dbg_context { | ||
| data.source_locations_enabled.set(true) |
ljedrz
commented
Oct 16, 2018
ContributorAuthor
@varkor thanks for the review! Semicolons added. |
varkor
commented
Oct 16, 2018
Contributor
@bors r+ rollup |
bors
commented
Oct 16, 2018
Collaborator
📌 Commit 24b74b2 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 18, 2018
…=varkor Cleanup the rest of codegen_llvm - improve common patterns - convert string literals with `to_owned` - remove explicit `return`s - whitespace & formatting improvements
bors added a commit
that referenced
this pull request
Oct 18, 2018
Rollup of 18 pull requests Successful merges: - #54646 (improve documentation on std::thread::sleep) - #54933 (Cleanup the rest of codegen_llvm) - #54964 (Run both lldb and gdb tests) - #55016 (Deduplicate some code and compile-time values around vtables) - #55031 (Improve verify_llvm_ir config option) - #55050 (doc std::fmt: the Python inspiration is already mentioned in precedin…) - #55077 (rustdoc: Use dyn keyword when rendering dynamic traits) - #55080 (Detect if access to localStorage is forbidden by the user's browser) - #55090 (regression test for move out of borrow via pattern) - #55102 (resolve: Do not skip extern prelude during speculative resolution) - #55104 (Add test for #34229) - #55111 ([Rustc Book] Explain --cfg's arguments) - #55122 (Cleanup mir/borrowck) - #55127 (Remove HybridBitSet::dummy) - #55128 (Fix LLVMRustInlineAsmVerify return type mismatch) - #55142 (miri: layout should not affect CTFE checks (outside of validation)) - #55151 (Cleanup nll) - #55161 ([librustdoc] Disable spellcheck for search field)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_ownedreturns