rustdoc: don't prefer dynamic linking in doc tests by pnkfelix · Pull Request #54939 · rust-lang/rust

pnkfelix · 2018-10-09T21:07:23Z

This is an attempt to address the regression in #54478

This may be a case where the cure is worse than the disease, at least in the short term...

cc @alexcrichton

rust-highfive · 2018-10-09T21:07:34Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2018-10-09T21:11:10Z

@bors try

bors · 2018-10-09T21:11:22Z

⌛ Trying commit 9a76c93 with merge 40d4795...

@alexcrichton

…c-tests, r=<try> [WIP] rustdoc: don't prefer dynamic linking in doc tests This is an attempt to address the regression in #54478 This may be a case where the cure is worse than the disease, at least in the short term... cc @alexcrichton

alexcrichton · 2018-10-09T22:04:07Z

Ok I finally got around to my local machine, and it looks like this passes ./x.py test with the commit I've added to update some UI test output. Other than that let's see what crater has to say...

pnkfelix · 2018-10-09T22:27:07Z

oh darn I clearly should have left a blank line there! 😆

pnkfelix · 2018-10-09T23:29:35Z

@craterbot run name=rustdoc-test-static-cling start=master#0e07c4281c343e9e15a0a8fca79538ad1a8eb513 end=try#40d4795669493f1965de7c44029c69552134fe1f mode=build-and-test

craterbot · 2018-10-09T23:29:37Z

👌 Experiment rustdoc-test-static-cling created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-10-09T23:29:40Z

🚧 Experiment rustdoc-test-static-cling is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-10-12T07:28:33Z

🎉 Experiment rustdoc-test-static-cling is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

alexcrichton · 2018-10-12T16:48:07Z

Well the good news is that this fixed 10 crates. The bad news is that it regressed 23000 crates.

@pietroalbini random selections of error logs look sort of confusing, did this run have errors in the middle perhaps?

Mark-Simulacrum · 2018-10-12T17:00:56Z

Yes, I believe the conclusion was that the run itself errored (rather than this PR causing most of the failures).

@craterbot run name=rustdoc-test-static-cling-1 start=master#0e07c4281c343e9e15a0a8fca79538ad1a8eb513 end=try#40d4795669493f1965de7c44029c69552134fe1f mode=build-and-test

craterbot · 2018-10-12T17:00:58Z

👌 Experiment rustdoc-test-static-cling-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-10-12T17:01:02Z

🚧 Experiment rustdoc-test-static-cling-1 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-10-16T19:32:23Z

🎉 Experiment rustdoc-test-static-cling-1 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2018-10-16T20:37:00Z

https://crater-reports.s3.amazonaws.com/rustdoc-test-static-cling-1/try%2340d4795669493f1965de7c44029c69552134fe1f/reg/docmatic-0.1.2/log.txt
A few of these: https://crater-reports.s3.amazonaws.com/rustdoc-test-static-cling-1/try%2340d4795669493f1965de7c44029c69552134fe1f/reg/restson-0.4.0/log.txt
https://crater-reports.s3.amazonaws.com/rustdoc-test-static-cling-1/try%2340d4795669493f1965de7c44029c69552134fe1f/reg/structopt-flags-0.1.0/log.txt

Haven't tried to reproduce locally but those are the failures that look possibly non-spurious. The wrong crate/mismatched types is the only one I'm super concerned with -- but since it's one case out of ~80k crates tested it seems unlikely that it's actually a problem. As such, presuming we're not expecting a serious performance regression here, I think this is ready to go

pnkfelix · 2018-10-16T21:27:39Z

(I just want someone from https://www.rust-lang.org/en-US/team.html#Rustdoc-team to give a 👍 here before we go and land it...)

pnkfelix · 2018-10-16T21:27:56Z

r? @QuietMisdreavus

QuietMisdreavus · 2018-10-16T22:37:58Z

Based on @alexcrichton's reasoning in #54478 (comment), this gets a +1 from me. It would be nice to know why it was set like that in the first place, but since it was set like that for as long as rustdoc has had doctests, i doubt we'll know for sure.

pnkfelix · 2018-10-17T00:23:52Z

@bors r=QuietMisdreavus

bors · 2018-10-17T00:23:53Z

📌 Commit cbca688 has been approved by QuietMisdreavus

bors · 2018-10-17T06:42:23Z

⌛ Testing commit cbca688 with merge 9d7f0da...

@alexcrichton

…c-tests, r=QuietMisdreavus rustdoc: don't prefer dynamic linking in doc tests This is an attempt to address the regression in #54478 This may be a case where the cure is worse than the disease, at least in the short term... cc @alexcrichton

bors · 2018-10-17T09:13:46Z

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 9d7f0da to master...

@ghost

[beta] Rollup backports Merged and approved: * #54300: Updated RELEASES.md for 1.30.0 * #54939: rustdoc: don't prefer dynamic linking in doc tests * #54671: resolve: Scale back hard-coded extern prelude additions on 2015 edition * #55102: resolve: Do not skip extern prelude during speculative resolution r? @ghost

@QuietMisdreavus

rustdoc: Don't modify library path for doctests It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic` (since #54939). r? @QuietMisdreavus

Use default of preferring static over dynamic linking in rustdoc tests.
9a76c93

rust-highfive assigned nikomatsakis Oct 9, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2018

pnkfelix mentioned this pull request Oct 9, 2018
[1.30 beta] Test suite of the jemalloc-ctl crate is failing #54478
Closed

Update a rustdoc ui test whose output has changed
cbca688

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2018

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 12, 2018

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2018

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 16, 2018

pnkfelix changed the title ~~[WIP] rustdoc: don't prefer dynamic linking in doc tests~~rustdoc: don't prefer dynamic linking in doc testsOct 16, 2018

pnkfelix added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. I-nominated labels Oct 16, 2018

pnkfelix requested a review from Mark-Simulacrum October 16, 2018 21:23

rust-highfive assigned QuietMisdreavus and unassigned nikomatsakis Oct 16, 2018

pnkfelix removed the request for review from Mark-Simulacrum October 16, 2018 21:28

pnkfelix added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2018

Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 16, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2018

bors merged commit cbca688 into rust-lang:masterOct 17, 2018

emilyalbini mentioned this pull request Oct 18, 2018
[beta] Rollup backports #55184
Merged

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 18, 2018

This was referenced Dec 3, 2018
rustdoc: Add option to persist doc test executables #56189
Merged
rustdoc: Don't modify library path for doctests #56514
Merged

QuietMisdreavus mentioned this pull request Jan 2, 2019
rustdoc: multiple matching crates #56901
Closed

Uh oh!

Uh oh!

Conversation

pnkfelix commented Oct 9, 2018

Uh oh!

rust-highfive commented Oct 9, 2018

Uh oh!

pnkfelix commented Oct 9, 2018

Uh oh!

bors commented Oct 9, 2018

Uh oh!

alexcrichton commented Oct 9, 2018

Uh oh!

pnkfelix commented Oct 9, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pnkfelix commented Oct 9, 2018

Uh oh!

craterbot commented Oct 9, 2018• edited by emilyalbini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

craterbot commented Oct 9, 2018

Uh oh!

craterbot commented Oct 12, 2018

Uh oh!

alexcrichton commented Oct 12, 2018

Uh oh!

Mark-Simulacrum commented Oct 12, 2018

Uh oh!

craterbot commented Oct 12, 2018

Uh oh!

craterbot commented Oct 12, 2018

Uh oh!

craterbot commented Oct 16, 2018

Uh oh!

Mark-Simulacrum commented Oct 16, 2018

Uh oh!

pnkfelix commented Oct 16, 2018

Uh oh!

pnkfelix commented Oct 16, 2018

Uh oh!

QuietMisdreavus commented Oct 16, 2018

Uh oh!

pnkfelix commented Oct 17, 2018

Uh oh!

bors commented Oct 17, 2018

Uh oh!

bors commented Oct 17, 2018

Uh oh!

bors commented Oct 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

pnkfelix commented Oct 9, 2018•
edited
Loading

craterbot commented Oct 9, 2018•
edited by emilyalbini
Loading