Skip to content

Make EvalContext::step public again - #55062

Merged
bors merged 2 commits into
rust-lang:masterfrom
bjorn3:ecx-step-public
Oct 15, 2018
Merged

Make EvalContext::step public again#55062
bors merged 2 commits into
rust-lang:masterfrom
bjorn3:ecx-step-public

Conversation

@bjorn3

@bjorn3bjorn3 commented Oct 14, 2018

Copy link
Copy Markdown
Member

This is needed for priroda

Fixes#55061

@rust-highfive

rust-highfive commented Oct 14, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2018
@bjorn3

bjorn3 commented Oct 14, 2018

Copy link
Copy Markdown
MemberAuthor

r? @oli-obk

@oli-obk

oli-obk commented Oct 14, 2018

Copy link
Copy Markdown
Contributor

You should probably add a comment explaining that it's public for priroda

@bjorn3

bjorn3 commented Oct 14, 2018

Copy link
Copy Markdown
MemberAuthor

Done

@oli-obk

oli-obk commented Oct 14, 2018

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 14, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 8a228fd has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2018
@bors

bors commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8a228fd with merge 9a4d26b542943f7c676fc82146b458ace39ecd11...

@bors

bors commented Oct 15, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 15, 2018
@rust-highfive

rust-highfive commented Oct 15, 2018

Copy link
Copy Markdown
Contributor

The job dist-mips64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:29baaa1b:start=1539585289621077691,finish=1539585289629534389,duration=8456698
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0a252677
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:302a5fe8
travis_time:start:302a5fe8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:185a2c52
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bjorn3

bjorn3 commented Oct 15, 2018

Copy link
Copy Markdown
MemberAuthor

Spurious failure

@oli-obk

oli-obk commented Oct 15, 2018

Copy link
Copy Markdown
Contributor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2018
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 15, 2018
@Manishearth
Rollup merge ofrust-lang#55062- bjorn3:ecx-step-public, r=oli-obk
96ab4a8
Make EvalContext::step public again
This is needed for priroda
Fixesrust-lang#55061
@ManishearthManishearth mentioned this pull request Oct 15, 2018
Merged
bors added a commit that referenced this pull request Oct 15, 2018
@bors
Auto merge of#55095- Manishearth:rollup, r=Manishearth
46880f4
Rollup of 11 pull requests
Successful merges:
- #54820 (Closes#54538: `unused_patterns` lint)
- #54963 (Cleanup rustc/session)
- #54991 (add test for #23189)
- #55025 (Add missing lifetime fragment specifier to error message.)
- #55047 (doc: make core::fmt::Error example more simple)
- #55048 (Don't collect to vectors where unnecessary)
- #55060 (clarify pointer add/sub function safety concerns)
- #55062 (Make EvalContext::step public again)
- #55066 (Fix incorrect link in println! documentation)
- #55081 (Deduplicate tests)
- #55088 (Update rustc documentation link)
Failed merges:
r? @ghost
@bors
bors merged commit 8a228fd into rust-lang:masterOct 15, 2018
@bjorn3
bjorn3 deleted the ecx-step-public branch October 16, 2018 05:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3@rust-highfive@oli-obk@bors@nikomatsakis