Uh oh!
There was an error while loading. Please reload this page.
Improve a few cases of collecting to an FxHash(Map/Set) - #55205
Merged
Conversation
rust-highfive
commented
Oct 19, 2018
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
estebank
commented
Oct 19, 2018
Contributor
@bors r+ |
bors
commented
Oct 19, 2018
Collaborator
📌 Commit 32768574e18c41b195464678280bf874ed595f01 has been approved by |
bors
commented
Oct 20, 2018
Collaborator
☔ The latest upstream changes (presumably #55114) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
commented
Oct 28, 2018
Contributor
@ljedrz You'll need to rebase against latest master. |
ljedrz
commented
Oct 28, 2018
ContributorAuthor
I know the drill, just haven't had access to a PC for a few days; I'll rebase tomorrow. |
ljedrzforce-pushed
the
faster_fxhashmap/set_population
branch
from
October 29, 2018 08:59
3276857 to
73d4eecCompareljedrz
commented
Oct 29, 2018
ContributorAuthor
@estebank rebased. |
estebank
commented
Oct 29, 2018
Contributor
@bors r+ rollup |
bors
commented
Oct 29, 2018
Collaborator
📌 Commit 73d4eec has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 30, 2018
…ion, r=estebank Improve a few cases of collecting to an FxHash(Map/Set) Either use `collect` or procure specified capacity when possible.
bors added a commit
that referenced
this pull request
Oct 30, 2018
Rollup of 12 pull requests Successful merges: - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`) - #55205 (Improve a few cases of collecting to an FxHash(Map/Set)) - #55450 (msp430: remove the whole Atomic* API) - #55459 (Add UI test for #49296) - #55472 (Use opt.take() instead of mem::replace(opt, None)) - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds) - #55474 (Fix validation false positive) - #55476 (Change a flat_map with 0/1-element vecs to a filter_map) - #55487 (Adjust Ids of path segments in visibility modifiers) - #55493 (Doc fixes) - #55494 (borrowck=migrate must look at parents of closures) - #55496 (Update clippy) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either use
collector procure specified capacity when possible.