Change the ICE from #55223 to a hard error by oli-obk · Pull Request #55262 · rust-lang/rust

oli-obk · 2018-10-22T12:44:21Z

cc @SimonSapin

r? @RalfJung

fixes#55287

RalfJung · 2018-10-23T12:27:20Z

@bors r+

bors · 2018-10-23T12:27:21Z

📌 Commit 2d960a5 has been approved by RalfJung

@SimonSapin

…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

RalfJung · 2018-10-24T18:56:19Z

@bors r+

(You are playing with fire, this PR is part of a rollup which might not pick up your typo fix. Let's see.^^)

bors · 2018-10-24T18:56:20Z

📌 Commit c2463af has been approved by RalfJung

…lfJung Change the ICE from rust-lang#55223 to a hard error

@SimonSapin

…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

@SimonSapin

…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

TimNN · 2018-11-06T18:22:17Z

Ping from triage @RalfJung: It looks like this PR is ready to be reviewed again.

estebank · 2018-11-06T18:34:58Z

Looking at the ICE fix commit, it is small enough that I feel confident giving my r+, assigning the approval to @RalfJung as he reviewed the other commits.

@bors r=RalfJung

bors · 2018-11-06T18:34:59Z

📌 Commit e70b634 has been approved by RalfJung

RalfJung · 2018-11-06T21:01:30Z

Ah, sorry for that. GitHub doesn't send emails when you change labels and also not for all kinds of force-pushes, so I had no idea this was waiting for me.

bors · 2018-11-06T23:36:20Z

⌛ Testing commit e70b634 with merge ddd4b19...

@SimonSapin

Change the ICE from #55223 to a hard error cc @SimonSapin r? @RalfJungfixes#55287

bors · 2018-11-07T02:28:04Z

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing ddd4b19 to master...

oli-obk force-pushed the dangling_alloc_id_ice branch from 4978e7f to 9f0a352Compare October 22, 2018 13:45

rust-highfive assigned RalfJung Oct 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2018

RalfJung reviewed Oct 23, 2018
View reviewed changes

Comment threadsrc/test/ui/consts/dangling-alloc-id-ice-2.nll.stderr Outdated

RalfJung reviewed Oct 23, 2018
View reviewed changes

Comment threadsrc/test/ui/consts/dangling-alloc-id-ice-2.rs Outdated

RalfJung reviewed Oct 23, 2018
View reviewed changes

Comment threadsrc/test/ui/consts/dangling-alloc-id-ice.rs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2018

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Oct 23, 2018
Rollup merge ofrust-lang#55262- oli-obk:dangling_alloc_id_ice, r=Ra…
1197831
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

emilyalbini mentioned this pull request Oct 23, 2018
Rollup of 19 pull requests #55295
Closed

RalfJung mentioned this pull request Oct 24, 2018
NLL: cast causes failure to promote to static #55288
Closed

kennytm mentioned this pull request Oct 24, 2018
Rollup of 28 pull requests #55320
Closed

estebank reviewed Oct 24, 2018
View reviewed changes

Comment threadsrc/librustc_mir/interpret/memory.rs Outdated

kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2018
Rollup merge ofrust-lang#55262- oli-obk:dangling_alloc_id_ice, r=Ra…
bff4637
…lfJung Change the ICE from rust-lang#55223 to a hard error

oli-obk mentioned this pull request Oct 25, 2018
const-eval ICE: allocation missing in dead_alloc_map #55287
Closed

kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2018
Rollup merge ofrust-lang#55262- oli-obk:dangling_alloc_id_ice, r=Ra…
2a7fff1
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

kennytm mentioned this pull request Oct 26, 2018
Rollup of 15 pull requests #55371
Closed

RalfJung mentioned this pull request Oct 26, 2018
Dangling raw pointers in constants will ICE in codegen #55353
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 26, 2018

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Oct 27, 2018
Rollup merge ofrust-lang#55262- oli-obk:dangling_alloc_id_ice, r=Ra…
805fcb6
…lfJung Change the ICE from rust-lang#55223 to a hard error cc @SimonSapin r? @RalfJung

Mark-Simulacrum mentioned this pull request Oct 27, 2018
Rollup of 13 pull requests #55425
Closed

kennytm mentioned this pull request Oct 28, 2018
Rollup of 11 pull requests #55433
Merged

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2018

This comment has been minimized.
Sign in to view

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2018

Turn ICE for dangling pointers into error
e70b634

oli-obk force-pushed the dangling_alloc_id_ice branch from 599eb12 to e70b634Compare October 29, 2018 12:14

TimNN added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 6, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2018

bors added a commit that referenced this pull request Nov 6, 2018
Auto merge of#55262- oli-obk:dangling_alloc_id_ice, r=RalfJung
ddd4b19
Change the ICE from #55223 to a hard error cc @SimonSapin r? @RalfJungfixes#55287

bors merged commit e70b634 into rust-lang:masterNov 7, 2018

oli-obk deleted the dangling_alloc_id_ice branch June 15, 2020 15:29

Uh oh!

Uh oh!

Conversation

oli-obk commented Oct 22, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Oct 23, 2018

Uh oh!

bors commented Oct 23, 2018

Uh oh!

Uh oh!

RalfJung commented Oct 24, 2018

Uh oh!

bors commented Oct 24, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

TimNN commented Nov 6, 2018

Uh oh!

estebank commented Nov 6, 2018

Uh oh!

bors commented Nov 6, 2018

Uh oh!

RalfJung commented Nov 6, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Nov 6, 2018

Uh oh!

bors commented Nov 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oli-obk commented Oct 22, 2018•
edited
Loading

RalfJung commented Nov 6, 2018•
edited
Loading