Uh oh!
There was an error while loading. Please reload this page.
miri engine: Stacked Borrows NG - #55270
Merged
Merged
Conversation
oli-obk
approved these changes
Oct 22, 2018
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Oct 22, 2018
Contributor
@bors r+ |
bors
commented
Oct 22, 2018
Collaborator
📌 Commit 6fb754aaddbdd8e77200849332e0db2e851ecc58 has been approved by |
RalfJung
commented
Oct 23, 2018
MemberAuthor
Cycling PR to hopefully get the PR-travis state unstuck. |
RalfJung
commented
Oct 23, 2018
MemberAuthor
@bors r=oli-obk |
bors
commented
Oct 23, 2018
Collaborator
💡 This pull request was already approved, no need to approve it again.
|
bors
commented
Oct 23, 2018
Collaborator
📌 Commit 6fb754aaddbdd8e77200849332e0db2e851ecc58 has been approved by |
This was referenced Oct 23, 2018
bors
commented
Oct 25, 2018
Collaborator
☔ The latest upstream changes (presumably #55347) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJungforce-pushed
the
stacked-borrows-ng
branch
from
October 26, 2018 11:39
6fb754a to
292d862CompareRalfJung
commented
Oct 26, 2018
MemberAuthor
Rebased. @bors r=oli-obk |
bors
commented
Oct 26, 2018
Collaborator
📌 Commit 292d862a633d993ded2ab8f57eaf2ceace56a6cc has been approved by |
This comment has been minimized.
This comment has been minimized.
…de)reference hooks work on places
RalfJungforce-pushed
the
stacked-borrows-ng
branch
from
October 28, 2018 11:24
292d862 to
95b19bbCompareRalfJung
commented
Oct 28, 2018
MemberAuthor
Rebased. @bors r=oli-obk |
bors
commented
Oct 28, 2018
Collaborator
📌 Commit 95b19bb has been approved by |
bors
commented
Oct 28, 2018
Collaborator
🌲 The tree is currently closed for pull requests below priority 1, this pull request will be tested once the tree is reopened |
bors
commented
Oct 29, 2018
Collaborator
bors added a commit
that referenced
this pull request
Oct 29, 2018
miri engine: Stacked Borrows NG For more refined tracking in miri, we do return untagged pointers from the memory abstraction after allocations and let the caller decide how to tag these. Also refactor the `tag_(de)reference` hooks so they can be more easily called in the ref-to-place and place-to-ref methods, and reorder things in validation: validation calls ref-to-place which (when running in miri) triggers some checks, so we want to run it rather late and catch other problems first. We also do not need to redundantly check the ref to be allocated any more, the checks miri does anyway imply thath. r? @oli-obk
bors
commented
Oct 29, 2018
Collaborator
☀️ Test successful - status-appveyor, status-travis |
bors added a commit
that referenced
this pull request
Nov 2, 2018
Add Retagging statements This adds a `Retag` statement kind to MIR, used to perform the retagging operation from [Stacked Borrows](https://www.ralfj.de/blog/2018/08/07/stacked-borrows.html). It also kills the old `Validate` statements that I added last year. NOTE: This includes #55270. Only [these commits are new](RalfJung/rust@stacked-borrows-ng...RalfJung:retagging).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more refined tracking in miri, we do return untagged pointers from the memory abstraction after allocations and let the caller decide how to tag these.
Also refactor the
tag_(de)referencehooks so they can be more easily called in the ref-to-place and place-to-ref methods, and reorder things in validation: validation calls ref-to-place which (when running in miri) triggers some checks, so we want to run it rather late and catch other problems first. We also do not need to redundantly check the ref to be allocated any more, the checks miri does anyway imply thath.r? @oli-obk