Uh oh!
There was an error while loading. Please reload this page.
Rename Value to Immediate for miri - #55393
Conversation
rust-highfive
commented
Oct 26, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Oct 28, 2018
☔ The latest upstream changes (presumably #54487) made this pull request unmergeable. Please resolve the merge conflicts. |
RalfJung
left a comment
There was a problem hiding this comment.
r=me with the nit fixed.
Thanks!
There was a problem hiding this comment.
The doc comment still refers to the old name.
Uh oh!
There was an error while loading. Please reload this page.
RalfJung
commented
Nov 2, 2018
LGTM. :) Needs a rebase though. |
ff8b4b2 to
90bfd0fCompareoli-obk
commented
Nov 2, 2018
done |
RalfJung
commented
Nov 2, 2018
@bors r+ |
bors
commented
Nov 2, 2018
📌 Commit 90bfd0fcd8b6e86cafea03b2da466a7277ececfc has been approved by |
bors
commented
Nov 2, 2018
☔ The latest upstream changes (presumably #55316) made this pull request unmergeable. Please resolve the merge conflicts. |
Co-Authored-By: oli-obk <github35764891676564198441@oli-obk.de>
90bfd0f to
400f997Compareoli-obk
commented
Nov 4, 2018
rebased |
RalfJung
commented
Nov 4, 2018
@bors r+ |
bors
commented
Nov 4, 2018
📌 Commit 400f997 has been approved by |
bors
commented
Nov 4, 2018
Rename `Value` to `Immediate` for miri r? @RalfJung
bors
commented
Nov 4, 2018
☀️ Test successful - status-appveyor, status-travis |
r? @RalfJung