Skip to content

Update stdsimd to branch with breaking bugfix - #55538

Closed
gnzlbg wants to merge 1 commit into
rust-lang:masterfrom
gnzlbg:crater_stdsimd_bug
Closed

Update stdsimd to branch with breaking bugfix#55538
gnzlbg wants to merge 1 commit into
rust-lang:masterfrom
gnzlbg:crater_stdsimd_bug

Conversation

@gnzlbg

@gnzlbggnzlbg commented Oct 31, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

DO NOT MERGE

This updates stdsimd to the test-fix branch containing this PR (rust-lang/stdarch#576) with a breaking soundness bugfix.

The plan was to schedule a crater run before merging this PR into stdsimd upstream.

r? @alexcrichton

@rust-highfive

rust-highfive commented Oct 31, 2018

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2018
@alexcrichton

alexcrichton commented Oct 31, 2018

Copy link
Copy Markdown
Member

@bors: try

@bors

bors commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit f0fecde with merge d781639...

bors added a commit that referenced this pull request Oct 31, 2018
@bors
Auto merge of#55538- gnzlbg:crater_stdsimd_bug, r=<try>
d781639
Update stdsimd to branch with breaking bugfix
**DO NOT MERGE**
---
This updates `stdsimd` to the `test-fix` branch containing this PR (rust-lang/stdarch#576) with a breaking soundness bugfix.
The plan was to schedule a crater run before merging this PR into stdsimd upstream.
r? @alexcrichton
@bors

bors commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@alexcrichton

alexcrichton commented Oct 31, 2018

Copy link
Copy Markdown
Member

@craterbot run start=master#05812fa8c588473f03e3fa7cf59cd84f4f37c715 end=try#d7816399d50d407bbce1efe9dbadf8faaaf568fc mode=check-only

@craterbot

craterbot commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-55538 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2018
@craterbot

craterbot commented Oct 31, 2018

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-55538 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Nov 2, 2018

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-55538 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 2, 2018
@gnzlbg

gnzlbg commented Nov 2, 2018

Copy link
Copy Markdown
ContributorAuthor

@alexcrichton looks like there are two regressions, but they do look spurious.

@alexcrichton

alexcrichton commented Nov 2, 2018

Copy link
Copy Markdown
Member

Agreed! I think this indicates that it should be safe to land the change. Shall we land the stdsimd PR on master, then update this one and land it?

@alexcrichtonalexcrichton mentioned this pull request Nov 2, 2018
Merged
@gnzlbg

gnzlbg commented Nov 2, 2018

Copy link
Copy Markdown
ContributorAuthor

I'll send a new PR to rust-lang rust updating stdsimd to stdsimd/master

@gnzlbggnzlbg closed this Nov 2, 2018
@alexcrichtonalexcrichton mentioned this pull request Nov 2, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnzlbg@rust-highfive@alexcrichton@bors@craterbot