test/linkage-visibility: Ignore on musl targets by smaeul · Pull Request #55564 · rust-lang/rust

smaeul · 2018-11-01T01:35:11Z

DynamicLibrary uses libc's dlsym() function internally to find symbols.
Some implementations of dlsym(), like musl's, only look at dynamically-
exported symbols, as found in shared libraries. To also export symbols
from the main executable, pass --export-dynamic to the linker.

(Plus see here and here for examples of where this is necessary on glibc as well.)

rust-highfive · 2018-11-01T01:35:14Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

TimNN · 2018-11-13T18:30:39Z

Ping from triage @aturon / @rust-lang/compiler: This PR requires your review.

eddyb · 2018-11-13T18:38:45Z

r? @alexcrichton

alexcrichton · 2018-11-14T15:04:49Z

I think this will fail on Windows due to an unsupported linker argument? Perhaps the test could just be ignored on musl with a comment?

smaeul · 2018-11-15T03:36:29Z

I'm tempted to follow your suggestion and ignore the test for musl, but as I mentioned, it will also fail on at least glibc if the binaries are stripped, i.e. if CFLAGS or LDFLAGS includes -s. Are we assuming this isn't the case? That seems a bit fragile to me, but maybe it's not worth worrying about?

alexcrichton · 2018-11-15T13:41:21Z

Yeah the tests aren't necessarily guaranteed to run in all environments with all flags so we largely just do what we can to keep them running across various platforms

DynamicLibrary uses libc's dlsym() function internally to find symbols. Some implementations of dlsym(), like musl's, only look at dynamically- exported symbols, as found in shared libraries. To also export symbols from the main executable, we would need to pass --export-dynamic to the linker. Since this flag isn't available everywhere, ignore the test for now.

smaeul · 2018-11-15T13:55:02Z

Ok, I've updated the PR to ignore the test

alexcrichton · 2018-11-15T14:17:35Z

@bors: r+

bors · 2018-11-15T14:17:37Z

📌 Commit 8c8ff6a has been approved by alexcrichton

test/linkage-visibility: Ignore on musl targets DynamicLibrary uses libc's dlsym() function internally to find symbols. Some implementations of dlsym(), like musl's, only look at dynamically- exported symbols, as found in shared libraries. To also export symbols from the main executable, pass --export-dynamic to the linker. (Plus see [here](https://stackoverflow.com/questions/4184017) and [here](https://stackoverflow.com/questions/6121838) for examples of where this is necessary on glibc as well.)

bors · 2018-11-16T06:27:42Z

⌛ Testing commit 8c8ff6a with merge 2066caa...

test/linkage-visibility: Ignore on musl targets DynamicLibrary uses libc's dlsym() function internally to find symbols. Some implementations of dlsym(), like musl's, only look at dynamically- exported symbols, as found in shared libraries. To also export symbols from the main executable, pass --export-dynamic to the linker. (Plus see [here](https://stackoverflow.com/questions/4184017) and [here](https://stackoverflow.com/questions/6121838) for examples of where this is necessary on glibc as well.)

bors · 2018-11-16T08:43:39Z

💔 Test failed - status-appveyor

alexcrichton · 2018-11-17T08:24:17Z

@bors: retry

bors · 2018-11-17T08:48:52Z

⌛ Testing commit 8c8ff6a with merge 7df57bd74d5bc26502daa1b95c40fae8605542c7...

bors · 2018-11-17T11:04:36Z

💔 Test failed - status-appveyor

alexcrichton · 2018-11-17T11:34:38Z

@bors: retry rollup

test/linkage-visibility: Ignore on musl targets DynamicLibrary uses libc's dlsym() function internally to find symbols. Some implementations of dlsym(), like musl's, only look at dynamically- exported symbols, as found in shared libraries. To also export symbols from the main executable, pass --export-dynamic to the linker. (Plus see [here](https://stackoverflow.com/questions/4184017) and [here](https://stackoverflow.com/questions/6121838) for examples of where this is necessary on glibc as well.)

@ghost

Rollup of 25 pull requests Successful merges: - #55562 (Add powerpc- and powerpc64-unknown-linux-musl targets) - #55564 (test/linkage-visibility: Ignore on musl targets) - #55827 (A few tweaks to iterations/collecting) - #55834 (Forward the ABI of the non-zero sized fields of an union if they have the same ABI) - #55857 (remove unused dependency) - #55862 (in which the E0618 "expected function" diagnostic gets a makeover) - #55867 (do not panic just because cargo failed) - #55894 (miri enum discriminant handling: Fix treatment of pointers, better error when it is undef) - #55916 (Make miri value visitor usfeful for mutation) - #55919 (core/tests/num: Simplify `test_int_from_str_overflow()` test code) - #55923 (reword #[test] attribute error on fn items) - #55935 (appveyor: Use VS2017 for all our images) - #55949 (ty: return impl Iterator from Predicate::walk_tys) - #55952 (Update to Clang 7 on CI.) - #55953 (#53488 Refactoring UpvarId) - #55962 (rustdoc: properly calculate spans for intra-doc link resolution errors) - #55963 (Stress test for MPSC) - #55968 (Clean up some non-mod-rs stuff.) - #55970 (Miri backtrace improvements) - #56007 (CTFE: dynamically make sure we do not call non-const-fn) - #56011 (Replace data.clone() by Arc::clone(&data) in mutex doc.) - #56012 (avoid shared ref in UnsafeCell::get) - #56016 (Add VecDeque::resize_with) - #56027 (docs: Add missing backtick in object_safety.rs docs) - #56043 (remove "approx env bounds" if we already know from trait) Failed merges: r? @ghost

Rollup of 25 pull requests Successful merges: - #55562 (Add powerpc- and powerpc64-unknown-linux-musl targets) - #55564 (test/linkage-visibility: Ignore on musl targets) - #55827 (A few tweaks to iterations/collecting) - #55834 (Forward the ABI of the non-zero sized fields of an union if they have the same ABI) - #55857 (remove unused dependency) - #55862 (in which the E0618 "expected function" diagnostic gets a makeover) - #55867 (do not panic just because cargo failed) - #55894 (miri enum discriminant handling: Fix treatment of pointers, better error when it is undef) - #55916 (Make miri value visitor useful for mutation) - #55919 (core/tests/num: Simplify `test_int_from_str_overflow()` test code) - #55923 (reword #[test] attribute error on fn items) - #55949 (ty: return impl Iterator from Predicate::walk_tys) - #55952 (Update to Clang 7 on CI.) - #55953 (#53488 Refactoring UpvarId) - #55962 (rustdoc: properly calculate spans for intra-doc link resolution errors) - #55963 (Stress test for MPSC) - #55968 (Clean up some non-mod-rs stuff.) - #55970 (Miri backtrace improvements) - #56007 (CTFE: dynamically make sure we do not call non-const-fn) - #56011 (Replace data.clone() by Arc::clone(&data) in mutex doc.) - #56012 (avoid shared ref in UnsafeCell::get) - #56016 (Add VecDeque::resize_with) - #56027 (docs: Add missing backtick in object_safety.rs docs) - #56043 (remove "approx env bounds" if we already know from trait) - #56059 (Increase `Duration` approximate equal threshold to 1us)

rust-highfive assigned aturon Nov 1, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2018

rust-highfive assigned alexcrichton and unassigned aturon Nov 13, 2018

smaeul force-pushed the test-fixes-2 branch from fb2c3ad to 8c8ff6aCompare November 15, 2018 13:53

smaeul changed the title ~~test/linkage-visibility: Ensure symbols are visible to dlsym~~test/linkage-visibility: Ignore on musl targetsNov 15, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2018

emilyalbini mentioned this pull request Nov 15, 2018
Rollup of 15 pull requests #55990
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2018

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 17, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 17, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2018

kennytm mentioned this pull request Nov 17, 2018
Rollup of 17 pull requests #56026
Closed

emilyalbini mentioned this pull request Nov 18, 2018
Rollup of 25 pull requests #56051
Merged

bors merged commit 8c8ff6a into rust-lang:masterNov 19, 2018

smaeul deleted the test-fixes-2 branch November 23, 2018 04:20

smaeul restored the test-fixes-2 branch April 25, 2019 02:51

smaeul deleted the test-fixes-2 branch April 25, 2019 02:53

Uh oh!

Uh oh!

Conversation

smaeul commented Nov 1, 2018

Uh oh!

rust-highfive commented Nov 1, 2018

Uh oh!

TimNN commented Nov 13, 2018

Uh oh!

eddyb commented Nov 13, 2018

Uh oh!

alexcrichton commented Nov 14, 2018

Uh oh!

smaeul commented Nov 15, 2018

Uh oh!

alexcrichton commented Nov 15, 2018

Uh oh!

smaeul commented Nov 15, 2018

Uh oh!

alexcrichton commented Nov 15, 2018

Uh oh!

bors commented Nov 15, 2018

Uh oh!

bors commented Nov 16, 2018

Uh oh!

bors commented Nov 16, 2018

Uh oh!

alexcrichton commented Nov 17, 2018

Uh oh!

bors commented Nov 17, 2018

Uh oh!

bors commented Nov 17, 2018

Uh oh!

alexcrichton commented Nov 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants