Uh oh!
There was an error while loading. Please reload this page.
Fixes #31076 - #55694
Conversation
Add test for incompleately implemented add trait, see issue rust-lang#31076
self.associated_item can return none, replace unwrap with '?' and bubble up None value instead of panicking
rust-highfive
commented
Nov 5, 2018
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rust-highfive
commented
Nov 5, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
add call to tcx.sess.delay_span_bug before returning none to make sure error is presented to user
oli-obk
commented
Nov 5, 2018
@bors r+ rollup |
bors
commented
Nov 5, 2018
📌 Commit 3063977 has been approved by |
oli-obk
commented
Nov 5, 2018
Thanks! |
jsirs
commented
Nov 5, 2018
Thank you for the time and responsiveness |
Rollup of 11 pull requests Successful merges: - #55490 (resolve: Fix ICE in macro import error recovery) - #55597 (std: Enable usage of `thread_local!` through imports) - #55601 (Fix tracking issue numbers for some unstable features) - #55621 (Add precision for create_dir function) - #55644 (ci: Add Dockerfile for dist-powerpcspe-linux) - #55664 (Make "all possible cases" help message uniform with existing help messages) - #55689 (miri: binary_op_val -> binary_op_imm) - #55694 (Fixes#31076) - #55696 (NLL Diagnostic Review 3: Missing errors for borrows of union fields) - #55700 (Update ui tests with respect to NLL) - #55703 (Update `configure --help` (via configure.py) to reflect decoupling of debug+optimize)
No description provided.