Uh oh!
There was an error while loading. Please reload this page.
Consume optimization fuel from the MIR inliner - #55739
Merged
Merged
Conversation
rust-highfive
commented
Nov 7, 2018
Contributor
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
reviewed
Nov 7, 2018
Uh oh!
There was an error while loading. Please reload this page.
eddyb
commented
Nov 7, 2018
Contributor
nikomatsakis
requested changes
Nov 7, 2018
nikomatsakis
left a comment
Contributor
There was a problem hiding this comment.
r=me with the order switched
This makes it easier to debug mis-optimizations that occur during inlining. Thanks to @nikomatsakis for the suggestion!
wesleywiserforce-pushed
the
mir_inline_fuel
branch
from
November 7, 2018 13:17
9384b1e to
e72afa9Comparewesleywiser
commented
Nov 7, 2018
MemberAuthor
@bors r=nikomatsakis |
bors
commented
Nov 7, 2018
Collaborator
📌 Commit e72afa9 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Nov 8, 2018
…matsakis Consume optimization fuel from the MIR inliner This makes it easier to debug mis-optimizations that occur during inlining. Thanks to @nikomatsakis for the suggestion!
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Nov 9, 2018
…matsakis Consume optimization fuel from the MIR inliner This makes it easier to debug mis-optimizations that occur during inlining. Thanks to @nikomatsakis for the suggestion!
bors added a commit
that referenced
this pull request
Nov 9, 2018
Rollup of 17 pull requests Successful merges: - #55576 (Clarify error message for -C opt-level) - #55633 (Support memcpy/memmove with differing src/dst alignment) - #55638 (Fix ICE in msg_span_from_free_region on ReEmpty) - #55659 (rustc: Delete grouping logic from the musl target) - #55719 (Sidestep link error from rustfix'ed code by using a *defined* static.) - #55736 (Elide anon lifetimes in conflicting impl note) - #55739 (Consume optimization fuel from the MIR inliner) - #55742 (Avoid panic when matching function call) - #55753 (borrow_set: remove a helper function and a clone it uses) - #55755 (Improve creation of 3 IndexVecs) - #55758 ([regression - rust2018]: unused_mut lint false positives on nightly) - #55760 (Remove intermediate font specs) - #55761 (mir: remove a hacky recursive helper function) - #55774 (wasm32-unknown-emscripten expects the rust_eh_personality symbol) - #55777 (Use `Lit` rather than `P<Lit>` in `ast::ExprKind`.) - #55783 (Deprecate mpsc channel selection) - #55788 (rustc: Request ansi colors if stderr isn't a tty) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to debug mis-optimizations that occur during
inlining. Thanks to @nikomatsakis for the suggestion!