Uh oh!
There was an error while loading. Please reload this page.
Upgrade LLVM to trunk, still version 8 - #55835
Conversation
rust-highfive
commented
Nov 9, 2018
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Nov 9, 2018
|
alexcrichton
commented
Nov 10, 2018
@bors: try |
bors
commented
Nov 10, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
bors
commented
Nov 10, 2018
💔 Test failed - status-travis |
rust-highfive
commented
Nov 10, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
67053e5 to
224ec5cComparealexcrichton
commented
Nov 10, 2018
@bors: try Gotta prime those caches |
bors
commented
Nov 10, 2018
⌛ Trying commit 224ec5c3a984f1a98dc9a2cd08ef2ae005471d63 with merge dbda7ea8913700f3c33951571c2cad2ea416d88e... |
alexcrichton
commented
Nov 10, 2018
@rust-timer build dbda7ea8913700f3c33951571c2cad2ea416d88e |
rust-timer
commented
Nov 10, 2018
Success: Queued dbda7ea8913700f3c33951571c2cad2ea416d88e with parent 42959a2, comparison URL. |
bors
commented
Nov 11, 2018
☔ The latest upstream changes (presumably #54864) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-timer
commented
Nov 11, 2018
Finished benchmarking try commit dbda7ea8913700f3c33951571c2cad2ea416d88e |
alexcrichton
commented
Nov 11, 2018
Well by golly gee those are some good numbers, surprising! |
nikic
commented
Nov 11, 2018
Those are some very nice results! At least the improvements on inflate are primarilty due to https://reviews.llvm.org/D53245 -- this used to spend ~25% of the time applying DomTree updates in JumpThreading and now no longer does. |
1ff0bef to
28d7334Comparealexcrichton
commented
Nov 11, 2018
Rebased! I've done some (hopefully) thorough testing locally and I've discovered... amazingly zero regressions! Should be ready to go! |
Hi Alex, Thanks for dealing with this. It should have really been me doing the work, since I spawned the discussion! I was wondering: do you have a way to check for performance regressions? Thanks |
vext01
commented
Nov 12, 2018
Ah yes, I see you have a benchmarking bot :) Neat. |
alexcrichton
commented
Nov 12, 2018
@vext01 oh no worries! I ended up wanting to do it for unrelated reasons anyway and figured I could help bootstrap the process at least, I didn't expect it to go so smoothly, but I'm sure bors will have a thing or two to say about that |
nikomatsakis
commented
Nov 12, 2018
@bors r+ |
bors
commented
Nov 12, 2018
📌 Commit 28d73341204480bbbd82b189ee84f839bf8dd208 has been approved by |
Our mangling scheme is not C++'s, so tell LLD to not demangle anything so we can handle Rust-specific demangling ourselves.
This should handle recent symbol visibility changes happening, although we'll likely want to tweak this in the future!
629a9ed to
7215963Comparealexcrichton
commented
Nov 26, 2018
Oops, forgot to disable LLDB @bors: r=nikomatsakis |
bors
commented
Nov 26, 2018
📌 Commit 7215963 has been approved by |
bors
commented
Nov 26, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
bors
commented
Nov 26, 2018
💔 Test failed - status-travis |
rust-highfive
commented
Nov 26, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexcrichton
commented
Nov 26, 2018
@bors: retry |
RalfJung
commented
Nov 26, 2018
bors
commented
Nov 26, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
bors
commented
Nov 26, 2018
☀️ Test successful - status-appveyor, status-travis |
nnethercote
commented
Nov 29, 2018
Final perf results from the landing are here. Very nice results, mostly on opt builds. |
This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!