Skip to content

[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds) - #55893

Merged
bors merged 2 commits into
rust-lang:betafrom
pnkfelix:issue-55810-beta-backport-of-pr-55819
Nov 13, 2018
Merged

[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds)#55893
bors merged 2 commits into
rust-lang:betafrom
pnkfelix:issue-55810-beta-backport-of-pr-55819

Conversation

@pnkfelix

@pnkfelixpnkfelix commented Nov 12, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Backport of 5f91373 from (beta-accepted) PR #55819

Fix#55810
Fix#55806

@rust-highfive

rust-highfive commented Nov 12, 2018

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Nov 12, 2018

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2018
@pnkfelixpnkfelix changed the title Typecheck patterns of all match arms first, so we get types for bindings[beta] Typecheck patterns of all match arms first, so we get types for bindingsNov 12, 2018
@pnkfelix

pnkfelix commented Nov 12, 2018

Copy link
Copy Markdown
ContributorAuthor

This was beta-accepted by @estebank so I'm going to treat that as the r+ here

@pnkfelix

pnkfelix commented Nov 12, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r=estebank

@bors

bors commented Nov 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 1c0cc97 has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2018
@emilyalbini

emilyalbini commented Nov 12, 2018

Copy link
Copy Markdown
Member

Can you also include #55828 in this?

@pnkfelix

pnkfelix commented Nov 12, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

as requested, cherry-picked the commit from #55828 into this PR

@pnkfelix

pnkfelix commented Nov 12, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors r=estebank

@bors

bors commented Nov 12, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 1e145d1 has been approved by estebank

@pnkfelixpnkfelix changed the title [beta] Typecheck patterns of all match arms first, so we get types for bindings[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds)Nov 12, 2018
@emilyalbini

emilyalbini commented Nov 12, 2018

Copy link
Copy Markdown
Member

@bors p=10 (beta backports)

@bors

bors commented Nov 12, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e145d1 with merge c341a59...

bors added a commit that referenced this pull request Nov 12, 2018
@bors
Auto merge of#55893- pnkfelix:issue-55810-beta-backport-of-pr-55819…
c341a59
…, r=estebank
[beta] backport rollup (typeck match arms eagerly; add rustc_promotable to unsigneds)
Backport of 5f91373 from (beta-accepted) PR #55819Fix#55810Fix#55806
@bors

bors commented Nov 13, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing c341a59 to beta...

@bors
bors merged commit 1e145d1 into rust-lang:betaNov 13, 2018
@goffriegoffrie mentioned this pull request Nov 14, 2018
Closed
@CentrilCentril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pnkfelix@rust-highfive@bors@emilyalbini@Centril@estebank@oli-obk