Expand std::pin module docs and rename std::pin::Pinned to PhantomPinned by cramertj · Pull Request #55992 · rust-lang/rust

cramertj · 2018-11-15T23:50:50Z

jonhoo · 2018-11-16T04:12:30Z

Shouldn't this be Box<T> and &mut T? We have an impl Unpin for Box<T> where T: !Unpin, right?

Those are also Unpin, but I was specifically referring to the Pin-wrapped types to clarify that Pin does not make something !Unpin.

jonhoo · 2018-11-20T04:45:15Z

I think we may want to say "no later code", or something along those lines, instead of "other functions". The contract around Pin talks about what cannot happen "in the future", but the current text doesn't currently say that.

TimNN · 2018-11-27T18:24:15Z

Ping from triage @withoutboats: This PR requires your review.

TimNN · 2018-12-04T18:27:53Z

Ping from triage @withoutboats / @rust-lang/libs: This PR requires your review.

bors · 2018-12-08T06:20:44Z

☔ The latest upstream changes (presumably #56578) made this pull request unmergeable. Please resolve the merge conflicts.

cramertj · 2018-12-10T18:20:57Z

Ping @rust-lang/libs can one of y'all make a decision here? I don't think there's much to be said that hasn't been already on the stabilization thread.

alexcrichton · 2018-12-10T20:33:21Z

@rfcbot fcp merge

To confirm we're all on board with the renaming, but I suspect this won't take long

rfcbot · 2018-12-10T20:33:22Z

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2018-12-12T19:04:35Z

🔔 This is now entering its final comment period, as per the review above. 🔔

alexcrichton · 2018-12-12T19:08:08Z

Ok great! @cramertj want to rebase this and I'll r+?

cramertj · 2018-12-12T20:24:51Z

@alexcrichton done!

alexcrichton · 2018-12-12T20:34:27Z

@bors: r+

bors · 2018-12-12T20:34:28Z

📌 Commit 709b751 has been approved by alexcrichton

bors · 2018-12-12T21:04:41Z

⌛ Testing commit 709b751 with merge 0076f58...

@withoutboats

Expand std::pin module docs and rename std::pin::Pinned to PhantomPinned cc #49150, #55766 r? @withoutboats

bors · 2018-12-12T23:55:56Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0076f58 to master...

rust-highfive assigned withoutboats Nov 15, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2018

cramertj mentioned this pull request Nov 15, 2018
[Stabilization] Pin APIs #55766
Closed
5 tasks

jonhoo reviewed Nov 16, 2018
View reviewed changes

Comment threadsrc/libcore/pin.rs Outdated

RalfJung reviewed Nov 19, 2018
View reviewed changes

Comment threadsrc/libcore/pin.rs Outdated

RalfJung reviewed Nov 19, 2018
View reviewed changes

Comment threadsrc/libcore/pin.rs Outdated

cramertj force-pushed the pin-docs branch from a2d4315 to f90be53Compare November 19, 2018 22:27

jonhoo reviewed Nov 20, 2018
View reviewed changes

alexcrichton added the T-libs-api [DEPRECATED; DO NOT USE] label Dec 10, 2018

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 12, 2018

cramertj added 2 commits December 12, 2018 12:23

Expand documantation for std::pin module
94856a7

Rename Pinned marker type to PhantomPinned
709b751

cramertj force-pushed the pin-docs branch from f90be53 to 709b751Compare December 12, 2018 20:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2018

bors added a commit that referenced this pull request Dec 12, 2018
Auto merge of#55992- cramertj:pin-docs, r=alexcrichton
0076f58
Expand std::pin module docs and rename std::pin::Pinned to PhantomPinned cc #49150, #55766 r? @withoutboats

bors merged commit 709b751 into rust-lang:masterDec 12, 2018

cramertj deleted the pin-docs branch December 13, 2018 00:31

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 22, 2018

SimonSapin mentioned this pull request Dec 27, 2018
Call poly_project_and_unify_type on types that contain inference types #56838
Merged

Uh oh!

Uh oh!

Conversation

cramertj commented Nov 15, 2018

Uh oh!

jonhooNov 16, 2018

Choose a reason for hiding this comment

Uh oh!

cramertjNov 16, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonhooNov 20, 2018

Choose a reason for hiding this comment

Uh oh!

TimNN commented Nov 27, 2018

Uh oh!

TimNN commented Dec 4, 2018

Uh oh!

bors commented Dec 8, 2018

Uh oh!

cramertj commented Dec 10, 2018

Uh oh!

alexcrichton commented Dec 10, 2018

Uh oh!

rfcbot commented Dec 10, 2018• edited by Kimundi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Dec 12, 2018

Uh oh!

alexcrichton commented Dec 12, 2018

Uh oh!

cramertj commented Dec 12, 2018

Uh oh!

alexcrichton commented Dec 12, 2018

Uh oh!

bors commented Dec 12, 2018

Uh oh!

bors commented Dec 12, 2018

Uh oh!

bors commented Dec 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

rfcbot commented Dec 10, 2018•
edited by Kimundi
Loading