Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks by varkor · Pull Request #56110 · rust-lang/rust

varkor · 2018-11-20T19:22:47Z

It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types.

This will also be more important in light of the changes at #54125.

cc @RalfJung

rust-highfive · 2018-11-20T19:22:51Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

RalfJung · 2018-11-20T19:29:35Z

Is it possible to write tests that show examples of how this changes things?

cramertj · 2018-11-20T19:30:52Z

r=me with a test added.

varkor · 2018-11-20T20:46:07Z

I've added a test and removed one that I don't think should apply any more, because the infinite type errors kick in before the infinite uninhabitedness checking ones (as references were the only way to cause this kind of infinite checking).

varkor · 2018-11-21T10:34:22Z

@cramertj: this required changing a few tests in the end, so it'd be great if you could re-check the changes!

cramertj · 2018-11-21T17:12:49Z

@bors r+

bors · 2018-11-21T17:12:50Z

📌 Commit 3de817cf07ecef20732504ee0a903d2cdceda0b6 has been approved by cramertj

emilyalbini · 2018-11-28T23:11:26Z

@bors r-

Failed in the rollup

…especting inhabitedness checks

varkor · 2018-11-29T21:00:30Z

@bors r=cramertj

@RalfJung

…cramertj Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types. This will also be more important in light of the changes at rust-lang#54125. cc @RalfJung

@ghost

Rollup of 9 pull requests Successful merges: - #55010 (Add template parameter debuginfo to generic types) - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks) - #56305 (update miri) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56394 (Deal with EINTR in net timeout tests) - #56395 (Stabilize dbg!(...)) - #56402 (Improve the unstable book example for #56408 [marker] trait) - #56406 (Update RLS and Rustfmt) - #56366 (Stabilize self_in_typedefs feature) Failed merges: r? @ghost

Centril · 2018-12-01T20:09:15Z

@varkor Same error seems to have turned up in #56408 (comment) which included this PR.

nikic · 2018-12-01T20:14:38Z

@Centril This is a spurious failure introduced by #49878, with a fix at #56396. It's unrelated to this PR :)

Centril · 2018-12-01T23:40:48Z

@bors rollup

(was in #56408)

@RalfJung

…cramertj Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types. This will also be more important in light of the changes at rust-lang#54125. cc @RalfJung

dlrobertson · 2018-12-02T03:02:23Z

#56396 landed... Thanks for you patience, this is probably due for a retry

varkor · 2018-12-02T04:34:36Z

@bors retry

@RalfJung

…cramertj Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types. This will also be more important in light of the changes at rust-lang#54125. cc @RalfJung

@ghost

Rollup of 14 pull requests Successful merges: - #56110 (Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks) - #56305 (update miri) - #56366 (Stabilize self_in_typedefs feature) - #56372 (Refer to the second borrow as the "second borrow" in E0501.rs) - #56394 (Deal with EINTR in net timeout tests) - #56395 (Stabilize dbg!(...)) - #56401 (Move VecDeque::resize_with out of the impl<T:Clone> block) - #56402 (Improve the unstable book example for #[marker] trait) - #56412 (Update tracking issue for `extern_crate_self`) - #56416 (Remove unneeded body class selector) - #56418 (Fix failing tidy (line endings on Windows)) - #56419 (Remove some uses of try!) - #56424 (Mention raw-ident syntax) - #56432 (Update issue number of `shrink_to` methods to point the tracking issue) Failed merges: r? @ghost

emilyalbini · 2018-12-02T18:31:16Z

@bors rollup-

bors · 2018-12-02T22:22:19Z

⌛ Testing commit 1cdf5df with merge b817d0b...

@RalfJung

Consider references and unions potentially inhabited during privacy-respecting inhabitedness checks It isn't settled exactly how references to uninhabited types and unions of uninhabited types should act, but we should be more conservative here, as it's likely it will be permitted to soundly have values of such types. This will also be more important in light of the changes at #54125. cc @RalfJung

bors · 2018-12-03T00:47:08Z

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing b817d0b to master...

rust-highfive assigned cramertj Nov 20, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2018

nikic mentioned this pull request Nov 20, 2018
Less conservative uninhabitedness check #54125
Merged

This comment has been minimized.
Sign in to view

Centril suggested changes Nov 20, 2018
View reviewed changes

Comment threadsrc/librustc/ty/inhabitedness/mod.rs Outdated
Comment threadsrc/librustc/ty/inhabitedness/mod.rs Outdated
Comment threadsrc/test/ui/always-inhabited-union-ref.rs Outdated

Centril approved these changes Nov 20, 2018
View reviewed changes

This comment has been minimized.
Sign in to view

varkor force-pushed the inhabitedness-union-enum branch from 1b3e434 to 3de817cCompare November 21, 2018 00:44

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2018

emilyalbini mentioned this pull request Nov 28, 2018
Rollup of 29 pull requests #56325
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2018

varkor added 5 commits November 29, 2018 20:58

Consider references and unions potentially inhabited during privacy-r…
682f0f8
…especting inhabitedness checks

Add a test for uninhabitedness changes
d2b3407

Clarify undecided semantics
32a8dec

Fix broken tests
46ef9f8

Fix error message after rebase
1cdf5df

varkor force-pushed the inhabitedness-union-enum branch from 3de817c to 1cdf5dfCompare November 29, 2018 21:00

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 1, 2018

Mark-Simulacrum mentioned this pull request Dec 1, 2018
Rollup of 9 pull requests #56408
Closed

Centril mentioned this pull request Dec 1, 2018
Rollup of 13 pull requests #56422
Closed

Centril mentioned this pull request Dec 2, 2018
Rollup of 14 pull requests #56427
Closed

Centril mentioned this pull request Dec 2, 2018
Rollup of 16 pull requests #56428
Closed

Centril mentioned this pull request Dec 2, 2018
Rollup of 15 pull requests #56429
Closed

Centril mentioned this pull request Dec 2, 2018
Rollup of 16 pull requests #56430
Closed

Centril mentioned this pull request Dec 2, 2018
Rollup of 14 pull requests #56437
Closed

bors merged commit 1cdf5df into rust-lang:masterDec 3, 2018

Uh oh!

Uh oh!

Conversation

varkor commented Nov 20, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Nov 20, 2018

Uh oh!

RalfJung commented Nov 20, 2018

Uh oh!

cramertj commented Nov 20, 2018

Uh oh!

This comment has been minimized.

varkor commented Nov 20, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

varkor commented Nov 21, 2018

Uh oh!

cramertj commented Nov 21, 2018

Uh oh!

bors commented Nov 21, 2018

Uh oh!

emilyalbini commented Nov 28, 2018

Uh oh!

varkor commented Nov 29, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Dec 1, 2018

Uh oh!

nikic commented Dec 1, 2018

Uh oh!

Centril commented Dec 1, 2018

Uh oh!

dlrobertson commented Dec 2, 2018

Uh oh!

varkor commented Dec 2, 2018

Uh oh!

emilyalbini commented Dec 2, 2018

Uh oh!

bors commented Dec 2, 2018

Uh oh!

bors commented Dec 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

varkor commented Nov 20, 2018•
edited
Loading

varkor commented Nov 29, 2018•
edited
Loading