Skip to content

Fix ICE with feature self_struct_ctor - #56205

Closed
estebank wants to merge 2 commits into
rust-lang:masterfrom
estebank:ice-ice-baby
Closed

Fix ICE with feature self_struct_ctor#56205
estebank wants to merge 2 commits into
rust-lang:masterfrom
estebank:ice-ice-baby

Conversation

@estebank

@estebankestebank commented Nov 25, 2018

Copy link
Copy Markdown
Contributor

Fix#56202.

@rust-highfive

rust-highfive commented Nov 25, 2018

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2018
@estebank

estebank commented Nov 25, 2018

Copy link
Copy Markdown
ContributorAuthor

CC @TheIronBorn

petrochenkov
petrochenkov reviewed Nov 25, 2018
View reviewed changes
Comment threadsrc/librustc/middle/reachable.rs Outdated
@nikomatsakis

nikomatsakis commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

@bors r+

I was going to ask @petrochenkov to review but it looks like they approve =)

@bors

bors commented Nov 26, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit 8d76f54 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2018
@kennytm
Rollup merge ofrust-lang#56205- estebank:ice-ice-baby, r=nikomatsakis
48276a7
Fix ICE with feature self_struct_ctor
Fixrust-lang#56202.
@kennytmkennytm mentioned this pull request Nov 27, 2018
Closed
@emilyalbiniemilyalbini mentioned this pull request Nov 28, 2018
Closed
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Nov 28, 2018
@emilyalbini
Rollup merge ofrust-lang#56205- estebank:ice-ice-baby, r=nikomatsakis
9642325
Fix ICE with feature self_struct_ctor
Fixrust-lang#56202.
scottmcm
scottmcm reviewed Nov 29, 2018
View reviewed changes
Comment threadsrc/test/ui/issues/issue-56202.stderr
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Nov 29, 2018
@emilyalbini
Rollup merge ofrust-lang#56205- estebank:ice-ice-baby, r=nikomatsakis
593cc39
Fix ICE with feature self_struct_ctor
Fixrust-lang#56202.
@emilyalbiniemilyalbini mentioned this pull request Nov 29, 2018
Closed
@alexreg

alexreg commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

This fixes #56199 too, right? You may want to add that to the PR comment, or else close it manually.

@kennytmkennytm mentioned this pull request Nov 30, 2018
Merged
@estebank

estebank commented Nov 30, 2018

Copy link
Copy Markdown
ContributorAuthor

@alexreg let's add a test in a follow up PR for it.

@estebankestebank mentioned this pull request Nov 30, 2018
Closed
@Centril

Centril commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

Let's see what happens with the rollup PR #56381 since it includes the changes in this PR since #56365 is rebased atop of it.

@alexreg

alexreg commented Nov 30, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Sure. If it goes through, we can do a very small follow-up PR.

@bors

bors commented Nov 30, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #56381) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2018
@Centril

Centril commented Nov 30, 2018

Copy link
Copy Markdown
Contributor

The commits in this PR were included in #56365 which was merged so closing therefore.

@CentrilCentril closed this Nov 30, 2018
@davidtwcodavidtwco mentioned this pull request Jan 20, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments
@scottmcmscottmcmscottmcm left review comments
+2 more reviewers
@alexregalexregalexreg left review comments
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@estebank@rust-highfive@nikomatsakis@bors@alexreg@Centril@petrochenkov@scottmcm