Uh oh!
There was an error while loading. Please reload this page.
read_c_str should call the AllocationExtra hooks - #56210
Merged
Merged
Conversation
oli-obk
commented
Nov 25, 2018
Contributor
@bors r+ |
bors
commented
Nov 25, 2018
Collaborator
📌 Commit 0fac350 has been approved by |
RalfJung
commented
Nov 25, 2018
MemberAuthor
@oli-obk found a bug and fixed it, could you review the latest commit as well? |
oli-obk
requested changes
Nov 25, 2018
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Nov 25, 2018
Contributor
@bors r+ |
bors
commented
Nov 25, 2018
Collaborator
📌 Commit 2472e83 has been approved by |
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Nov 25, 2018
read_c_str should call the AllocationExtra hooks I just hope we do not have other methods that bypass `get_bytes`/`get_bytes_mut`... (looking over the file, I could not find any) r? @oli-obk
bors added a commit
that referenced
this pull request
Nov 25, 2018
Rollup of 14 pull requests Successful merges: - #56024 (Don't auto-inline const functions) - #56045 (Check arg/ret sizedness at ExprKind::Path) - #56072 (Stabilize macro_literal_matcher) - #56075 (Encode a custom "producers" section in wasm files) - #56100 (generator fields are not necessarily initialized) - #56101 (Incorporate `dyn` into more comments and docs.) - #56144 (Fix BTreeSet and BTreeMap gdb pretty-printers) - #56151 (Move a flaky process test out of libstd) - #56170 (Fix self profiler ICE on Windows) - #56176 (Panic setup msg) - #56204 (Suggest correct enum variant on typo) - #56207 (Stabilize the int_to_from_bytes feature) - #56210 (read_c_str should call the AllocationExtra hooks) - #56211 ([master] Forward-ports from beta) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just hope we do not have other methods that bypass
get_bytes/get_bytes_mut... (looking over the file, I could not find any)r? @oli-obk