Uh oh!
There was an error while loading. Please reload this page.
Miri and miri-related code contains repetitions of (n << amt) >> amt - #56233
Conversation
rust-highfive
commented
Nov 26, 2018
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Nov 26, 2018
|
rust-highfive
commented
Nov 26, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
eddyb
commented
Nov 26, 2018
You have accidental submodule changes. Please use |
eddyb
commented
Nov 26, 2018
r? @oli-obk |
(Oh, you have multiple commits, you'll have to use |
rust-highfive
commented
Nov 26, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kenta7777
commented
Nov 26, 2018
@eddyb Thank you for your advice. I updated submodules and pushed again. |
eddyb
commented
Nov 26, 2018
@kenta7777 When I said |
rust-highfive
commented
Nov 26, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Dylan-DPC-zz
commented
Dec 3, 2018
Pinging from triage @kenta7777 any updates on this? |
eddyb
commented
Dec 3, 2018
r? @oli-obk |
oli-obk
commented
Dec 3, 2018
The implementation looks good to me. @kenta7777 can you do another rebase and remove the submodule changes from your second commit? You can |
bors
commented
Dec 3, 2018
☔ The latest upstream changes (presumably #56305) made this pull request unmergeable. Please resolve the merge conflicts. |
kenta7777
commented
Dec 9, 2018
@oli-obk I apologize for the delay in replying to you. I'll revise my commits following your advice. |
712ed93 to
70e85adCompareoli-obk
commented
Dec 11, 2018
@kenta7777 looks like you got some commits from another PR in here again. This time around a git fetch origin
git rebase -i origin/masterand removing all commits that are not yours should work |
rust-highfive
commented
Dec 11, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kenta7777
commented
Dec 11, 2018
oli-obk
commented
Dec 11, 2018
Don't worry about it, everything is fixable with git! No need to open a new PR. Can you show me the output of |
kenta7777
commented
Dec 11, 2018
This is an output of |
Ok, great! So the following commands should get you back to business: Remember to remove any commits that are not yours from the list that shows up |
kenta7777
commented
Dec 11, 2018
@oli-obk Thank you for your advice. I rebased following your advice. After that, This output is the first three commit log. But, This is the output of |
oli-obk
commented
Dec 12, 2018
You can now use |
36617d4 to
dcbd573Comparerust-highfive
commented
Dec 12, 2018
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kenta7777
commented
Dec 17, 2018
Because of my some work, I'll work on this bug fix a few days later. |
rust-highfive
commented
Jan 2, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
stokhos
commented
Jan 14, 2019
Ping from triage @kenta7777 have you been able to make any progress on this? |
No. I'm considering fixing this error, but I can't find the way how to do. |
There was a problem hiding this comment.
The issue is that sign_extend returns a u128 which contains the bits of a i128. It should suffice to cast the result to i128.
rust-highfive
commented
Jan 17, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kenta7777
commented
Jan 20, 2019
@oli-obk Thank you for your review. I have fixed the issue. |
oli-obk
commented
Jan 20, 2019
The code looks perfect now. Please do another rebase (that should get rid of the merge commits). Just running |
@oli-obk I just ran |
3dfed67 to
b80332eCompareoli-obk
commented
Jan 25, 2019
@bors r+ |
bors
commented
Jan 25, 2019
📌 Commit b80332e has been approved by |
oli-obk
commented
Jan 25, 2019
@bors rollup |
Miri and miri-related code contains repetitions of `(n << amt) >> amt` I reduced some code repetitions contains `(n << amt) >> amt`. This pull request is related to rust-lang#49937.
Rollup of 5 pull requests Successful merges: - #56233 (Miri and miri-related code contains repetitions of `(n << amt) >> amt`) - #57645 (distinguish "no data" from "heterogeneous" in ABI) - #57734 (Fix evaluating trivial drop glue in constants) - #57886 (Add suggestion for moving type declaration before associated type bindings in generic arguments.) - #57890 (Fix wording in diagnostics page) Failed merges: r? @ghost
I reduced some code repetitions contains
(n << amt) >> amt.This pull request is related to #49937.