Uh oh!
There was an error while loading. Please reload this page.
Override <RangeInclusive as Iterator>::try_(r)fold - #56563
Closed
sinkuu wants to merge 2 commits into
Closed
Conversation
rust-highfive
commented
Dec 6, 2018
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
sinkuu
commented
Dec 7, 2018
Uh oh!
There was an error while loading. Please reload this page.
sinkuuforce-pushed
the
range_inclusive_fold
branch
from
December 7, 2018 01:44
fc9de85 to
779066eComparesinkuuforce-pushed
the
range_inclusive_fold
branch
from
December 7, 2018 02:18
779066e to
46f6915CompareMember
kennytm
commented
Dec 15, 2018
Member
@scottmcm No idea 😐 |
Centril
commented
Dec 24, 2018
Contributor
bors
commented
Dec 24, 2018
Collaborator
✌️ @scottmcm can now approve this pull request |
scottmcm
commented
Jan 9, 2019
Member
Cross-reference: #57378 |
scottmcm
commented
Jan 21, 2019
Member
r? @rkruppe Can you take this one too, please, since you have the other RangeInclusive perf one? I think it's better that someone actually on libs handles this, and I'm biased here. |
hanna-kruppe
commented
Jan 22, 2019
Contributor
Sorry, it doesn't seem like I'll be able to give this PR proper attention in the near future. Please assign someone else. PS: not sure if that's what you are saying, but I'm not on T-libs or even "affiliated". |
Centril
commented
Jan 22, 2019
Contributor
Ok... musical chairs... The luck has come to r? @Kimundi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #45222
folding inclusive ranges.try_rfoldforRangeis left unoverrided since I didn't see performance gain for it.Benchmarks: