Uh oh!
There was an error while loading. Please reload this page.
Add short emoji status to toolstate updates - #56758
Merged
Merged
Conversation
Manishearthforce-pushed
the
emoji-status-toolstate
branch
from
December 12, 2018 22:53
c25c570 to
ae893bbComparekennytm
commented
Dec 13, 2018
Member
@bors r+ rollup 😈 |
bors
commented
Dec 13, 2018
Collaborator
📌 Commit ae893bb has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 13, 2018
… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions.
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 14, 2018
… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions. r? @kennytm cc @rust-lang/infra @rust-lang/devtools
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Dec 14, 2018
… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions. r? @kennytm cc @rust-lang/infra @rust-lang/devtools
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Dec 14, 2018
… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions. r? @kennytm cc @rust-lang/infra @rust-lang/devtools
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Dec 15, 2018
… r=kennytm Add short emoji status to toolstate updates I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly I haven't been able to test it, and the actual emoji are just suggestions. r? @kennytm cc @rust-lang/infra @rust-lang/devtools
bors added a commit
that referenced
this pull request
Dec 15, 2018
Rollup of 14 pull requests Successful merges: - #56718 (Use libbacktrace pretty-printing) - #56725 (fix rust-lang/rust issue #50583) - #56731 (Add missing urls in ffi module docs) - #56738 (Fix private_no_mangle_fns message grammar) - #56746 (Add test of current behavior (infer free region within closure body)) - #56747 (target: remove Box returned by get_targets) - #56751 (Allow ptr::hash to accept fat pointers) - #56755 (Account for `impl Trait` when suggesting lifetime) - #56758 (Add short emoji status to toolstate updates) - #56760 (Deduplicate unsatisfied trait bounds) - #56769 (Add x86_64-unknown-uefi target) - #56792 (Bootstrap: Add testsuite for compiletest tool) - #56808 (Fixes broken links) - #56809 (Fix docs path to PermissionsExt) Failed merges: r? @ghost
ghost
reviewed
Dec 15, 2018
| long_message += '🎉 {} on {}: {} → {}.\n' \ | ||
| .format(tool, os, old, new) | ||
| emoji = "{}🎉".format(EMOJI.get(tool)) | ||
| if msg not in emoji_status: |
There was a problem hiding this comment.
I may just be missing it but I can't find msg referenced anywhere else. Should these be emoji?
emilyalbini
left a comment
Member
There was a problem hiding this comment.
This PR broke master. Reverting it.
cc @rust-lang/infra, CI doesn't check if publish_toolstate.py is valid before merging a PR
| return '' | ||
| short_message = "📣 Toolstate changed by {}! ({})" | ||
| .format(relevant_pr_number, '/'.join(emoji_status)) |
bors added a commit
that referenced
this pull request
Dec 15, 2018
Revert merge of #56758 - Manishearth:emoji-status-toolstate #56758 is breaking master. r? @ghost cc @Manishearth@kennytm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get a lot of these emails and it's good to know which ones I should be paying closer attention to -- i.e. the ones where clippy breaks. This adds a short emoji status report to the first line of the commit message, which shows up in notifications directly
I haven't been able to test it, and the actual emoji are just suggestions.
r? @kennytm
cc @rust-lang/infra @rust-lang/devtools