Add a note describing the type of the non-Copy moved variable by csmoe · Pull Request #56843 · rust-lang/rust

csmoe · 2018-12-15T11:02:30Z

davidtwco · 2018-12-17T10:46:16Z

Looks good to me, can merge this once existing review comments are resolved.

csmoe · 2018-12-17T10:57:16Z

@davidtwco oops, my fault, the .nll.stderr still unchanged, but while compiling with -Z borrowck=mir locally, the note was added indeed, how to trigger the diff in nll mode?

davidtwco · 2018-12-17T11:00:55Z

@davidtwco oops, my fault, the .nll.stderr still unchanged, but while compiling with -Z borrowck=mir locally, the note was added indeed, how to trigger the diff in nll mode?

I'm not exactly sure what you're asking - but if you want to run the tests with both compare modes, you'll need to change your config.toml. After that, running the UI tests with bless will update the NLL stderr files.

davidtwco · 2018-12-17T11:20:45Z

@davidtwco I mean note= was not append to ui/use/use-after-move-self.nll.stderr as this PR wanna fix. while compiling the single test case locally: ./build/.../rustc src/test/ui/use/use-after-move-self.rs -Z borrowck=mir, the note= was outputted indeed. but ./x.py test src/test/ui didn't complain about diff between stderr and stdout.

If there is no difference between the AST and NLL output then there is only a .stderr file, does this explain what you are seeing?

davidtwco · 2018-12-17T13:48:47Z

@bors r+

bors · 2018-12-17T13:48:48Z

📌 Commit 37c3561 has been approved by davidtwco

@davidtwco

Add a note describing the type of the non-Copy moved variable Closesrust-lang#56654 r?@davidtwco

bors · 2018-12-20T19:18:23Z

⌛ Testing commit 37c3561 with merge afa2c0440f42243f75703fb3b2ce3e9324626575...

bors · 2018-12-20T19:26:08Z

💔 Test failed - status-travis

alexcrichton · 2018-12-20T19:29:54Z

@bors: retry

0.3.2 contains a breaking change malept/crypto-hash#6

@davidtwco

Add a note describing the type of the non-Copy moved variable Closesrust-lang#56654 r?@davidtwco

bors · 2018-12-22T09:45:02Z

⌛ Testing commit 37c3561 with merge 6f4f93d17c18132d100dc63dcb8cbd53070f7fba...

bors · 2018-12-22T11:06:12Z

💔 Test failed - status-travis

davidtwco · 2018-12-22T12:55:33Z

@csmoe could you rebase this PR on top of master (a PR gets merged with master before running any tests but that means that some new tests that this might apply to won’t have had their output updated - hence the need to rebase) and make sure you are running and updating the test output for the NLL compare mode too?

csmoe · 2018-12-22T12:57:58Z

@davidtwco soon.

bors · 2018-12-26T18:57:50Z

☔ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts.

describe index with _

davidtwco · 2018-12-29T22:03:29Z

@bors r+

bors · 2018-12-29T22:03:29Z

📌 Commit 48de0ff has been approved by davidtwco

bors · 2018-12-29T23:45:51Z

⌛ Testing commit 48de0ff with merge a35cf79...

@davidtwco

Add a note describing the type of the non-Copy moved variable Closes#56654 r?@davidtwco

bors · 2018-12-30T02:17:25Z

☀️ Test successful - status-appveyor, status-travis
Approved by: davidtwco
Pushing a35cf79 to master...

rust-highfive assigned davidtwco Dec 15, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2018

This comment has been minimized.
Sign in to view

csmoe force-pushed the non-copy branch from ccd1be6 to 74e4c98Compare December 15, 2018 12:00

This comment has been minimized.
Sign in to view

csmoe force-pushed the non-copy branch from 74e4c98 to 9ca2902Compare December 15, 2018 12:55

bjorn3 requested changes Dec 15, 2018
View reviewed changes

Comment threadsrc/test/ui/borrowck/borrowck-move-out-from-array.mir.stderr
Comment threadsrc/test/ui/use/use-after-move-self.rs Outdated

This comment has been minimized.
Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2018

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Dec 20, 2018
Rollup merge ofrust-lang#56843- csmoe:non-copy, r=davidtwco
063e4a2
Add a note describing the type of the non-Copy moved variable Closesrust-lang#56654 r?@davidtwco

emilyalbini mentioned this pull request Dec 20, 2018
Rollup of 19 pull requests #57005
Closed

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2018

Centril added a commit to Centril/rust that referenced this pull request Dec 22, 2018
Rollup merge ofrust-lang#56843- csmoe:non-copy, r=davidtwco
e0fb972
Add a note describing the type of the non-Copy moved variable Closesrust-lang#56654 r?@davidtwco

Centril mentioned this pull request Dec 22, 2018
Rollup of 41 pull requests #57058
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 22, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2018

csmoe force-pushed the non-copy branch 2 times, most recently from 6fcf80b to d3251f8Compare December 23, 2018 13:18

retrieve ty info from place_ty
8d77c7c
describe index with _

csmoe force-pushed the non-copy branch from d3251f8 to dd6ce2dCompare December 27, 2018 11:10

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2018

matthewjasper reviewed Dec 27, 2018
View reviewed changes

Comment threadsrc/test/ui/use/use-after-move-self.rs Outdated

add non-copy note to stderr
48de0ff

csmoe force-pushed the non-copy branch from dd6ce2d to 48de0ffCompare December 29, 2018 02:36

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2018

bors added a commit that referenced this pull request Dec 29, 2018
Auto merge of#56843- csmoe:non-copy, r=davidtwco
a35cf79
Add a note describing the type of the non-Copy moved variable Closes#56654 r?@davidtwco

bors merged commit 48de0ff into rust-lang:masterDec 30, 2018

bors mentioned this pull request Dec 30, 2018
[WIP] Take 2: change how MIR represents Place #54426
Closed

Uh oh!

Uh oh!

Conversation

csmoe commented Dec 15, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

davidtwco commented Dec 17, 2018

Uh oh!

csmoe commented Dec 17, 2018

Uh oh!

davidtwco commented Dec 17, 2018

Uh oh!

This comment has been minimized.

davidtwco commented Dec 17, 2018

Uh oh!

davidtwco commented Dec 17, 2018

Uh oh!

bors commented Dec 17, 2018

Uh oh!

bors commented Dec 20, 2018

Uh oh!

bors commented Dec 20, 2018

Uh oh!

This comment has been minimized.

alexcrichton commented Dec 20, 2018

Uh oh!

bors commented Dec 22, 2018

Uh oh!

bors commented Dec 22, 2018

Uh oh!

davidtwco commented Dec 22, 2018

Uh oh!

csmoe commented Dec 22, 2018

Uh oh!

bors commented Dec 26, 2018

Uh oh!

Uh oh!

davidtwco commented Dec 29, 2018

Uh oh!

bors commented Dec 29, 2018

Uh oh!

bors commented Dec 29, 2018

Uh oh!

bors commented Dec 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants