Skip to content

panic when calling MaybeUninhabited::into_inner on uninhabited type - #57145

Merged
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:panic-if-uninhabited
Jan 5, 2019
Merged

panic when calling MaybeUninhabited::into_inner on uninhabited type#57145
bors merged 2 commits into
rust-lang:masterfrom
RalfJung:panic-if-uninhabited

Conversation

@RalfJung

@RalfJungRalfJung commented Dec 27, 2018•
edited
Loading

Copy link
Copy Markdown
Member

I do this by adding an internal-only intrinsic panic_if_uninhabited. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!

@rust-highfive

rust-highfive commented Dec 27, 2018

Copy link
Copy Markdown
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2018
oli-obk
oli-obk reviewed Dec 27, 2018
View reviewed changes
Comment threadsrc/librustc_codegen_ssa/mir/block.rs Outdated
@zackmdavis

zackmdavis commented Dec 30, 2018

Copy link
Copy Markdown
Contributor

I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!

I fear I don't have domain expertise here, either. 😰 @oli-obk, since you already commented, are you able to take over the review?

r? @oli-obk

@oli-obk

oli-obk commented Dec 30, 2018

Copy link
Copy Markdown
Contributor

So... I am confident that the impl does what it promises. I just don't know if I can single handedly sign off on this.

I think it would be enough for @rust-lang/libs to sign off on this, although it kind of touches language and compiler.

@oli-obkoli-obk added I-nominated T-libs-api [DEPRECATED; DO NOT USE] labels Dec 30, 2018
@alexcrichton

alexcrichton commented Jan 2, 2019

Copy link
Copy Markdown
Member

@bors: try

@bors

bors commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c118b17 with merge c8bd38c4de0d52227df9d7c04afd10f3080e9a6a...

@alexcrichton

alexcrichton commented Jan 2, 2019

Copy link
Copy Markdown
Member

Er sorry, just now realizing that the implementation already does this, we're just adding something else under that umbrella. Sounds good to me!

@bors: r+

@bors

bors commented Jan 2, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit c118b17 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jan 3, 2019
@Mark-Simulacrum
Rollup merge ofrust-lang#57145- RalfJung:panic-if-uninhabited, r=al…
2701289
…excrichton
panic when calling MaybeUninhabited::into_inner on uninhabited type
I do this by adding an internal-only intrinsic `panic_if_uninhabited`. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jan 3, 2019
Closed
@bors

bors commented Jan 5, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c118b17 with merge 8c2d0f4...

bors added a commit that referenced this pull request Jan 5, 2019
@bors
Auto merge of#57145- RalfJung:panic-if-uninhabited, r=alexcrichton
8c2d0f4
panic when calling MaybeUninhabited::into_inner on uninhabited type
I do this by adding an internal-only intrinsic `panic_if_uninhabited`. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!
@bors

bors commented Jan 5, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8c2d0f4 to master...

@borsbors mentioned this pull request Jan 5, 2019
Closed
@bors
bors merged commit c118b17 into rust-lang:masterJan 5, 2019
@rust-highfive

rust-highfive commented Jan 5, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #57145!

Tested on commit 8c2d0f4.
Direct link to PR: #57145

💔 miri on linux: test-pass → test-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jan 5, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#57145!
ffef539
Tested on commit rust-lang/rust@8c2d0f4.
Direct link to PR: <rust-lang/rust#57145>
💔 miri on linux: test-pass → test-fail (cc @oli-obk@RalfJung@eddyb, @rust-lang/infra).
@RalfJung
RalfJung deleted the panic-if-uninhabited branch January 9, 2019 15:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung@rust-highfive@zackmdavis@oli-obk@alexcrichton@bors