Skip to content

Change std::error::Error trait documentation to talk about source instead of cause - #57192

Merged
bors merged 1 commit into
rust-lang:masterfrom
czipperz:error_trait_doc_cause_to_source
Jan 12, 2019
Merged

Change std::error::Error trait documentation to talk about source instead of cause#57192
bors merged 1 commit into
rust-lang:masterfrom
czipperz:error_trait_doc_cause_to_source

Conversation

@czipperz

@czipperzczipperz commented Dec 29, 2018

Copy link
Copy Markdown
Contributor

Resolves#57056

@rust-highfive

rust-highfive commented Dec 29, 2018

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kimundi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2018
@wesleywiser

wesleywiser commented Jan 10, 2019

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9de89531989202e928369217a3725ee6822b3e0d has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019
@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9de89531989202e928369217a3725ee6822b3e0d with merge c6799596938212e885586e68578e7f4d47f77223...

@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019
@czipperz

czipperz commented Jan 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@wesleywiser I'm going to rebase this commit and see if that fixes anything

@czipperz
czipperzforce-pushed the error_trait_doc_cause_to_source branch from 9de8953 to 564a24cCompareJanuary 10, 2019 06:20
@wesleywiser

wesleywiser commented Jan 10, 2019

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 564a24c has been approved by wesleywiser

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019
@CentrilCentril mentioned this pull request Jan 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019
@Centril
Rollup merge ofrust-lang#57192- czipperz:error_trait_doc_cause_to_s…
40a819b
…ource, r=wesleywiser
Change std::error::Error trait documentation to talk about `source` instead of `cause`
Resolvesrust-lang#57056
@CentrilCentril mentioned this pull request Jan 12, 2019
Merged
bors added a commit that referenced this pull request Jan 12, 2019
@bors
Auto merge of#57542- Centril:rollup, r=Centril
d6525ef
Rollup of 26 pull requests
Successful merges:
- #56425 (Redo the docs for Vec::set_len)
- #56906 (Issue #56905)
- #57042 (Don't call `FieldPlacement::count` when count is too large)
- #57175 (Stabilize `let` bindings and destructuring in constants and const fn)
- #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`)
- #57296 (Fixed the link to the ? operator)
- #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache)
- #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic)
- #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main)
- #57433 (Add link destination for `read-ownership`)
- #57434 (Remove `CrateNum::Invalid`.)
- #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.)
- #57450 (actually take a slice in this example)
- #57459 (Reference tracking issue for inherent associated types in diagnostic)
- #57463 (docs: Fix some 'second-edition' links)
- #57466 (Remove outdated comment)
- #57493 (use structured suggestion when casting a reference)
- #57498 (make note of one more normalization that Paths do)
- #57499 (note that FromStr does not work for borrowed types)
- #57505 (Remove submodule step from README)
- #57510 (Add a profiles section to the manifest)
- #57511 (Fix undefined behavior)
- #57519 (Correct RELEASES.md for 1.32.0)
- #57522 (don't unwrap unexpected tokens in `format!`)
- #57530 (Fixing a typographical error.)
- #57535 (Stabilise irrefutable if-let and while-let patterns)
Failed merges:
r? @ghost
@bors
bors merged commit 564a24c into rust-lang:masterJan 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KimundiKimundi

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@czipperz@rust-highfive@wesleywiser@bors@Kimundi