Skip to content

Parallelize and optimize parts of HIR map creation - #57232

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:par-collector-misc
Jan 14, 2019
Merged

Parallelize and optimize parts of HIR map creation#57232
bors merged 1 commit into
rust-lang:masterfrom
Zoxc:par-collector-misc

Conversation

@Zoxc

@ZoxcZoxc commented Dec 31, 2018

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2018
@Zoxc

Zoxc commented Dec 31, 2018

Copy link
Copy Markdown
ContributorAuthor

The addition of ModuleItems and iteration of module item-likes is the same code as in #51487

@Zoxc

Zoxc commented Dec 31, 2018

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

⌛ Trying commit d407822 with merge 55497bb...

bors added a commit that referenced this pull request Dec 31, 2018
@bors
Auto merge of#57232- Zoxc:par-collector-misc, r=<try>
55497bb
Parallelize and optimize parts of HIR map creation
r? @michaelwoerister
@bors

bors commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #57061) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc

Zoxc commented Dec 31, 2018

Copy link
Copy Markdown
ContributorAuthor

@rust-timer build 55497bb

@rust-timer

rust-timer commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

Success: Queued 55497bb with parent aeed63b, comparison URL.

@rust-timer

rust-timer commented Dec 31, 2018

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit 55497bb

@Zoxc
Zoxcforce-pushed the par-collector-misc branch from d407822 to 68cd086CompareDecember 31, 2018 18:59
@Zoxc

Zoxc commented Jan 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Blocked on #51487

@michaelwoerister

michaelwoerister commented Jan 7, 2019

Copy link
Copy Markdown
Member

Two thoughts:

  • Doing the measurements in single-threaded mode doesn't do the optimizations justice, I guess.
  • Would the work done here be obsolete once we implement end-to-end queries?

@Zoxc

Zoxc commented Jan 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Would the work done here be obsolete once we implement end-to-end queries?

I'd need to know a more concrete plan to answer this, but it won't be obsolete assuming the HIR map is still around.

@michaelwoerister

michaelwoerister commented Jan 9, 2019

Copy link
Copy Markdown
Member

It's at least possible that there won't be a hir map in the current form, and that we rather build it lazily. There'd then be a bunch of queries providing the information that the map holds now (which automatically make building the map parallel). But I don't think anybody has a concrete design for this yet.

@bors

bors commented Jan 13, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc
Zoxcforce-pushed the par-collector-misc branch from 68cd086 to cbb5a00CompareJanuary 14, 2019 02:27
@michaelwoerister

michaelwoerister commented Jan 14, 2019

Copy link
Copy Markdown
Member

Ok, the changes here don't look too complicated. Let's do it!

@bors r+

Thanks, @Zoxc!

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit cbb5a00 has been approved by michaelwoerister

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
@Centril
Rollup merge ofrust-lang#57232- Zoxc:par-collector-misc, r=michaelw…
473e1aa
…oerister
Parallelize and optimize parts of HIR map creation
r? @michaelwoerister
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
@Centril
Rollup merge ofrust-lang#57232- Zoxc:par-collector-misc, r=michaelw…
0d883cb
…oerister
Parallelize and optimize parts of HIR map creation
r? @michaelwoerister
@CentrilCentril mentioned this pull request Jan 14, 2019
Merged
bors added a commit that referenced this pull request Jan 14, 2019
@bors
Auto merge of#57592- Centril:rollup, r=Centril
d106808
Rollup of 6 pull requests
Successful merges:
- #57232 (Parallelize and optimize parts of HIR map creation)
- #57418 (MetadataOnlyCodegenBackend: run the collector only once)
- #57465 (Stabilize cfg_target_vendor)
- #57477 (clarify resolve typo suggestion)
- #57556 (privacy: Fix private-in-public check for existential types)
- #57584 (Remove the `connect_timeout_unroutable` test.)
Failed merges:
r? @ghost
@bors
bors merged commit cbb5a00 into rust-lang:masterJan 14, 2019
@Zoxc
Zoxc deleted the par-collector-misc branch January 14, 2019 21:26
@aturonaturon mentioned this pull request Aug 16, 2019
Closed
37 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoeristermichaelwoerister

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc@bors@rust-timer@michaelwoerister@rust-highfive