Skip to content

rustc: Place wasm linker args first instead of last - #57337

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:prioritize-another
Jan 13, 2019
Merged

rustc: Place wasm linker args first instead of last#57337
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:prioritize-another

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

This ensures that arguments passed via -C link-arg can override the
first ones on the command line, for example allowing configuring of the
stack size.

This ensures that arguments passed via `-C link-arg` can override the
first ones on the command line, for example allowing configuring of the
stack size.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2019

@fitzgenfitzgen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexcrichton

Copy link
Copy Markdown
MemberAuthor

@bors: r=fitzgen

@bors

bors commented Jan 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit ae1a50d has been approved by fitzgen

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2019
@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ae1a50d with merge dc2eecffa3b776c968003cce46ea6231b04118d9...

@bors

bors commented Jan 10, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2019
@emilyalbini

Copy link
Copy Markdown
Member

@bors retry
AppVeyor... what's wrong with you today?

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2019
@zackmdaviszackmdavis removed their assignment Jan 13, 2019
@CentrilCentril mentioned this pull request Jan 13, 2019
@CentrilCentril mentioned this pull request Jan 13, 2019
@CentrilCentril mentioned this pull request Jan 13, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 13, 2019
…fitzgen
rustc: Place wasm linker args first instead of last
This ensures that arguments passed via `-C link-arg` can override the
first ones on the command line, for example allowing configuring of the
stack size.
@CentrilCentril mentioned this pull request Jan 13, 2019
bors added a commit that referenced this pull request Jan 13, 2019
Rollup of 4 pull requests
Successful merges:
- #57004 (Make `TokenStream` less recursive.)
- #57102 (NLL: Add union justifications to conflicting borrows.)
- #57337 (rustc: Place wasm linker args first instead of last)
- #57549 (Add #[must_use] message to Iterator and Future)
Failed merges:
r? @ghost
@bors
bors merged commit ae1a50d into rust-lang:masterJan 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@alexcrichton@rust-highfive@bors@emilyalbini@fitzgen@zackmdavis