Uh oh!
There was an error while loading. Please reload this page.
Change the IP address in the connect_timeout_unroutable test. - #57506
Closed
nnethercote wants to merge 1 commit into
Closed
Change the IP address in the connect_timeout_unroutable test.#57506nnethercote wants to merge 1 commit into
connect_timeout_unroutable test.#57506nnethercote wants to merge 1 commit into
Conversation
rust-highfive
commented
Jan 11, 2019
Contributor
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
nnethercote
commented
Jan 11, 2019
ContributorAuthor
I can't guarantee this will work universally, for reasons explained in the comment. But it fixes the test failure for my Ubuntu 18.04 box. |
nnethercote
commented
Jan 11, 2019
ContributorAuthor
Because the current address is reachable on some machines, which causes the test to fail. Fixesrust-lang#44698, rust-lang#50065.
nnethercoteforce-pushed
the
fix-connect_timeout_unroutable
branch
from
January 11, 2019 02:47
f4c2405 to
ca26d44Comparedtolnay
commented
Jan 11, 2019
Member
r? @sfackler |
nagisa
commented
Jan 11, 2019
Member
This test should just go. There are so many ways this could do something else for any IP that it makes no sense to test for it without mocking out the system call. |
nnethercote
commented
Jan 13, 2019
ContributorAuthor
nnethercote
commented
Jan 14, 2019
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the current address is reachable on some machines, which causes
the test to fail.
Fixes#44698, fixes#50065.