Skip to content

Add a debug_assert to Vec::set_len - #57589

Merged
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:vec-set_len-debug_assert
Jan 15, 2019
Merged

Add a debug_assert to Vec::set_len#57589
bors merged 1 commit into
rust-lang:masterfrom
scottmcm:vec-set_len-debug_assert

Conversation

@scottmcm

Copy link
Copy Markdown
Member

Following the precedent of #52972, which found llogiq/bytecount#42.

(This may well make a test fail; let's see what Travis says.)

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2019
@scottmcmscottmcm added the T-libs-api [DEPRECATED; DO NOT USE] label Jan 14, 2019
@Mark-Simulacrum

Copy link
Copy Markdown
Member

r? @alexcrichton

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jan 14, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1fd971c has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
…r=alexcrichton
Add a debug_assert to Vec::set_len
Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.
(This may well make a test fail; let's see what Travis says.)
Centril added a commit to Centril/rust that referenced this pull request Jan 14, 2019
…r=alexcrichton
Add a debug_assert to Vec::set_len
Following the precedent of rust-lang#52972, which found llogiq/bytecount#42.
(This may well make a test fail; let's see what Travis says.)
@CentrilCentril mentioned this pull request Jan 14, 2019
bors added a commit that referenced this pull request Jan 14, 2019
Rollup of 8 pull requests
Successful merges:
- #57043 (Fix poor worst case performance of set intersection)
- #57480 (Clean up and fix a bug in query plumbing)
- #57481 (provide suggestion for invalid boolean cast)
- #57540 (Modify some parser diagnostics to continue evaluating beyond the parser)
- #57570 (Querify local `plugin_registrar_fn` and `proc_macro_decls_static`)
- #57572 (Unaccept `extern_in_paths`)
- #57585 (Recover from item trailing semicolon)
- #57589 (Add a debug_assert to Vec::set_len)
Failed merges:
r? @ghost
@bors
bors merged commit 1fd971c into rust-lang:masterJan 15, 2019
@scottmcm
scottmcm deleted the vec-set_len-debug_assert branch January 15, 2019 01:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@scottmcm@rust-highfive@Mark-Simulacrum@alexcrichton@bors