Uh oh!
There was an error while loading. Please reload this page.
Add a query type which is always marked as red if it runs - #57770
Conversation
rust-highfive
commented
Jan 20, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
commented
Jan 20, 2019
@bors try |
bors
commented
Jan 20, 2019
⌛ Trying commit 980741a with merge 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1... |
bors
commented
Jan 20, 2019
☀️ Test successful - checks-travis |
Zoxc
commented
Jan 20, 2019
@rust-timer build 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 |
rust-timer
commented
Jan 20, 2019
Success: Queued 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 with parent 588f94b, comparison URL. |
rust-timer
commented
Jan 20, 2019
Finished benchmarking try commit 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 |
Zoxc
commented
Jan 20, 2019
@bors try |
bors
commented
Jan 20, 2019
⌛ Trying commit 0ccc8fa with merge ccd8d903fea581884646e7aacc105503e37ece94... |
rust-highfive
commented
Jan 20, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Jan 20, 2019
☀️ Test successful - checks-travis |
Xanewok
commented
Jan 20, 2019
@rust-timer build ccd8d903fea581884646e7aacc105503e37ece94 |
rust-timer
commented
Jan 20, 2019
Success: Queued ccd8d903fea581884646e7aacc105503e37ece94 with parent d38d6be, comparison URL. |
rust-timer
commented
Jan 20, 2019
Finished benchmarking try commit ccd8d903fea581884646e7aacc105503e37ece94 |
Zoxc
commented
Jan 21, 2019
@bors try |
bors
commented
Jan 21, 2019
Add a query type which is always marked as red if it runs This is useful for queries which produce results which are very likely to change if their inputs do. I also expect this to be useful for end to end queries because 1) we don't need `HashStable` impls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map. r? @michaelwoerister
rust-highfive
commented
Jan 21, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Jan 21, 2019
☀️ Test successful - checks-travis |
Zoxc
commented
Jan 21, 2019
@rust-timer build cb75345 |
rust-timer
commented
Jan 21, 2019
Success: Queued cb75345 with parent e730697, comparison URL. |
rust-timer
commented
Jan 21, 2019
Finished benchmarking try commit cb75345 |
michaelwoerister
commented
Jan 21, 2019
Thanks, @Zoxc. This looks good and I like how it is implemented. I had this implemented at some point (with an The biggest downside is that it relies on intuition on where it might be beneficial based on the current topology of query dependencies. If the topology changes (e.g. there are additional consumers of a query) then it would have to be re-evaluated if a given query should be Another downside is that it skews the data we collect about cache-hits. It gets harder to reason about what's actually going on as far as re-use is concerned. That being said, the above concerns are also true for The first thing I'd like to try is to remove |
michaelwoerister
commented
Jan 21, 2019
It actually shouldn't be too hard to collect data on this. All queries that are re-evaluated but then turn out to be green should go through this branch: rust/src/librustc/dep_graph/graph.rs Line 292 in ffee835 That should tell us how likely it is for a given query that it turns red if its inputs change. |
Zoxc
commented
Jan 22, 2019
@bors try |
Zoxc
commented
Feb 8, 2019
@michaelwoerister Yeah. |
rust-highfive
commented
Feb 8, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
michaelwoerister
commented
Feb 8, 2019
Great! @bors r+ |
bors
commented
Feb 8, 2019
📌 Commit b4a6f59 has been approved by |
bors
commented
Feb 9, 2019
⌛ Testing commit b4a6f59 with merge 6a1134da5894be1a23f3fe6fca38af049a7dd895... |
bors
commented
Feb 9, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Feb 9, 2019
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kennytm
commented
Feb 9, 2019
@bors retry 3 hour timeout |
bors
commented
Feb 9, 2019
⌛ Testing commit b4a6f59 with merge ee7091c79949ddd7bf86773183f750ab82eb8cc7... |
bors
commented
Feb 9, 2019
☀️ Test successful - checks-travis, status-appveyor |
bors
commented
Feb 9, 2019
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
kennytm
commented
Feb 10, 2019
@bors retry |
bors
commented
Feb 10, 2019
Add a query type which is always marked as red if it runs This is useful for queries which produce results which are very likely to change if their inputs do. I also expect this to be useful for end to end queries because 1) we don't need `HashStable` impls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map. r? @michaelwoerister
bors
commented
Feb 10, 2019
☀️ Test successful - checks-travis, status-appveyor |
This is useful for queries which produce results which are very likely to change if their inputs do.
I also expect this to be useful for end to end queries because 1) we don't need
HashStableimpls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map.r? @michaelwoerister