Skip to content

Remove lexical scope examples from std::mem::drop - #57927

Merged
bors merged 1 commit into
rust-lang:masterfrom
Alexendoo:mem-drop-nll-docs
Jan 27, 2019
Merged

Remove lexical scope examples from std::mem::drop#57927
bors merged 1 commit into
rust-lang:masterfrom
Alexendoo:mem-drop-nll-docs

Conversation

@Alexendoo

@AlexendooAlexendoo commented Jan 26, 2019

Copy link
Copy Markdown
Member

The example no longer produces an error in the 2018 edition

@Alexendoo
Remove lexical scope examples from std::mem::drop
9c9144f
The example no longer produces an error in the 2018 edition
@rust-highfive

rust-highfive commented Jan 26, 2019

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aidanhs (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2019
@Centril

Centril commented Jan 26, 2019

Copy link
Copy Markdown
Contributor

@bors rollup

@Centril

Centril commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

r? @Centril

@bors r+

@bors

bors commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 9c9144f has been approved by Centril

@rust-highfiverust-highfive assigned Centril and unassigned aidanhsJan 27, 2019
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
@Centril
Rollup merge ofrust-lang#57927- Alexendoo:mem-drop-nll-docs, r=Centril
450692e
Remove lexical scope examples from std::mem::drop
The example no longer produces an error in the 2018 edition
@CentrilCentril mentioned this pull request Jan 27, 2019
Closed
@bors

bors commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9c9144f with merge 01af120...

bors added a commit that referenced this pull request Jan 27, 2019
@bors
Auto merge of#57927- Alexendoo:mem-drop-nll-docs, r=Centril
01af120
Remove lexical scope examples from std::mem::drop
The example no longer produces an error in the 2018 edition
@bors

bors commented Jan 27, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 01af120 to master...

@bors
bors merged commit 9c9144f into rust-lang:masterJan 27, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alexendoo@rust-highfive@Centril@bors@aidanhs