Uh oh!
There was an error while loading. Please reload this page.
Move privacy checking later in the pipeline and make some passes run in parallel - #58010
Merged
Conversation
michaelwoerister
commented
Feb 6, 2019
Member
Looks good! Can you explain why you moved privacy checking? |
Zoxc
commented
Feb 6, 2019
ContributorAuthor
I moved it so it could run in parallel with other more expensive non-incremental passes (helps with incremental compilation). I want to get stability checking down there too, but it was giving me strange errors if done after type collecting, so I skipped that for now. |
michaelwoerister
commented
Feb 6, 2019
Member
bors
commented
Feb 6, 2019
Collaborator
📌 Commit 38bcd4b has been approved by |
bors
commented
Feb 7, 2019
Collaborator
bors added a commit
that referenced
this pull request
Feb 7, 2019
Move privacy checking later in the pipeline and make some passes run in parallel r? @michaelwoerister
bors
commented
Feb 7, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 7, 2019
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @michaelwoerister