Skip to content

Combine all builtin late lints and make lint checking parallel - #58019

Merged
bors merged 3 commits into
rust-lang:masterfrom
Zoxc:combine-late-lints
Mar 29, 2019
Merged

Combine all builtin late lints and make lint checking parallel#58019
bors merged 3 commits into
rust-lang:masterfrom
Zoxc:combine-late-lints

Conversation

@Zoxc

@ZoxcZoxc commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Blocked on #57293.

Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on winapi (@retep998 ;) )

r? @estebank

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 8d86971 to c76b767CompareJanuary 31, 2019 14:21
@estebank

estebank commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

r=me ++

@estebankestebank added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2019
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from c76b767 to abba103CompareFebruary 15, 2019 04:32
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from abba103 to 4b9290dCompareFebruary 26, 2019 12:22
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 4b9290d to 6ebb3cdCompareMarch 1, 2019 00:28
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 6ebb3cd to 52f4e6bCompareMarch 1, 2019 20:15
@estebank

estebank commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

This comment has been minimized.

Sign in to view
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 1, 2019
@estebank

estebank commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

@bors r- forgot this was blocked on #57293

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2019
@ZoxcZoxc mentioned this pull request Mar 8, 2019
Open
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 52f4e6b to d57f98eCompareMarch 9, 2019 22:03
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from d57f98e to 4cab76eCompareMarch 10, 2019 10:24
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 4cab76e to 86d8c49CompareMarch 13, 2019 01:58
@bors

This comment has been minimized.

Sign in to view
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 86d8c49 to 5eb24edCompareMarch 14, 2019 16:14
@ZoxcZoxc mentioned this pull request Mar 15, 2019
Merged
@Zoxc

Zoxc commented Mar 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors try

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 5eb24edc8d9921231ec8589c1f9d1e16489711a2 with merge eaad254355cc991c01011b6327e9cf27bfad670c...

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-travis
Build commit: eaad254355cc991c01011b6327e9cf27bfad670c

@Zoxc

Zoxc commented Mar 18, 2019

Copy link
Copy Markdown
ContributorAuthor

@rust-timer build eaad254355cc991c01011b6327e9cf27bfad670c

@rust-timer

rust-timer commented Mar 18, 2019

Copy link
Copy Markdown
Collaborator

Success: Queued eaad254355cc991c01011b6327e9cf27bfad670c with parent 0f88167, comparison URL.

@rust-timer

rust-timer commented Mar 18, 2019

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit eaad254355cc991c01011b6327e9cf27bfad670c

@estebankestebank added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 22, 2019
@Zoxc
Zoxcforce-pushed the combine-late-lints branch from 5eb24ed to dee389fCompareMarch 28, 2019 15:34
@Zoxc

Zoxc commented Mar 28, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=estebank

@bors

bors commented Mar 28, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit dee389f has been approved by estebank

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019
@Centril
Rollup merge ofrust-lang#58019- Zoxc:combine-late-lints, r=estebank
8794e21
Combine all builtin late lints and make lint checking parallel
Blocked on rust-lang#57293.
Cuts runtime of late lint checking from 3.222s to 0.546s with 8 threads on `winapi` (@retep998 ;) )
r? @estebank
@CentrilCentril mentioned this pull request Mar 29, 2019
Merged
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of#59513- Centril:rollup, r=Centril
41dee75
Rollup of 11 pull requests
Successful merges:
- #58019 (Combine all builtin late lints and make lint checking parallel)
- #59358 (Use `track_errors` instead of hand rolling)
- #59394 (warn -> deny duplicate match bindings)
- #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
- #59423 (Visit path in `walk_mac`)
- #59468 (musl: build toolchain libs with -fPIC)
- #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
- #59496 (Remove unnecessary with_globals calls)
- #59498 (Use 'write_all' instead of 'write' in example code)
- #59503 (Stablize {f32,f64}::copysign().)
- #59511 (Fix missed fn rename in #59284)
Failed merges:
r? @ghost
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of#59513- Centril:rollup, r=Centril
003382e
Rollup of 11 pull requests
Successful merges:
- #58019 (Combine all builtin late lints and make lint checking parallel)
- #59358 (Use `track_errors` instead of hand rolling)
- #59394 (warn -> deny duplicate match bindings)
- #59401 (bootstrap: build crates under libtest with -Z emit-stack-sizes)
- #59423 (Visit path in `walk_mac`)
- #59468 (musl: build toolchain libs with -fPIC)
- #59476 (Use `SmallVec` in `TokenStreamBuilder`.)
- #59496 (Remove unnecessary with_globals calls)
- #59498 (Use 'write_all' instead of 'write' in example code)
- #59503 (Stablize {f32,f64}::copysign().)
- #59511 (Fix missed fn rename in #59284)
Failed merges:
r? @ghost
@bors
bors merged commit dee389f into rust-lang:masterMar 29, 2019
@Zoxc
Zoxc deleted the combine-late-lints branch March 29, 2019 14:41
@aturonaturon mentioned this pull request Aug 16, 2019
Closed
37 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@estebankestebank

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc@rust-highfive@estebank@bors@rust-timer