submodule: update clippy from 6ce78d1 to 3bda548 by h-michael · Pull Request #58093 · rust-lang/rust

h-michael · 2019-02-03T10:16:03Z

rust-lang/rust-clippy@6ce78d1...3bda548

Rustup: unused trim result
Auto merge of #3727 - phansch:rustup_unused_trim, r=matthiaskrgr …
Travis: Don't run integration tests on every PR commit …
Auto merge of #3726 - phansch:some_renaming, r=oli-obk …
Fix ICE in vec_box lint and add run-rustfix …
Make vec_box MachineApplicable
Remove conditionals from base builds …
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100. …
Running util/dev to update README/CHANGELOG
Reworking function logic, and adding doc example. …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Skipping check if in external macro.
Adding lint for too many lines.
Updating number of lines for the failing test to be > 100. …
Moving tests to ui-toml to make use of clippy.toml
rustfmt
Adding back tests, but also reducing threshold by 1
Updating to just warn for one test.
Fix test broken by removing comment.
Changing single character string to a character match.
Updated readme.
Updating code to ignore rustfmt issue.
phansch and avborhanian
Update clippy_lints/src/types.rs …
Update clippy_lints/src/types.rs …
Auto merge of #3732 - phansch:fix_ice_3720, r=oli-obk …
Auto merge of #3731 - phansch:travis, r=phansch …
Auto merge of #2857 - avborhanian:master, r=phansch …
Fix breakage due to #58079 …
Auto merge of #3736 - mikerite:fix-build-20190203, r=phansch …

related with: #58024

rust-highfive · 2019-02-03T10:16:13Z

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-02-03T10:16:13Z

⚠️Warning⚠️

These commits modify submodules.

h-michael · 2019-02-03T10:19:08Z

r? @oli-obk

Xanewok · 2019-02-03T10:36:22Z

I believe this needs an update to Cargo.lock as well.

h-michael · 2019-02-03T10:39:29Z

@Xanewok I execute ./x.py build and abort.
But nothing changes.

Xanewok · 2019-02-03T11:05:43Z

Ah, the Clippy version seems frozen, my bad.

Looks good, @oli-obk I hope you don’t mind me merging this ASAP; I’d like to unbreak the pending RLS update.

r? @Xanewok

@bors r+ p=1

bors · 2019-02-03T11:05:44Z

📌 Commit 73c39bb has been approved by Xanewok

bors · 2019-02-03T11:40:20Z

⌛ Testing commit 73c39bb with merge e215c7a368972492b1a3d873fa3c325ce3071a0a...

bors · 2019-02-03T13:35:11Z

💔 Test failed - status-appveyor

h-michael · 2019-02-03T13:43:31Z

@bors retry

bors · 2019-02-03T13:43:32Z

@h-michael: 🔑 Insufficient privileges: not in try users

h-michael · 2019-02-03T13:43:57Z

@Xanewok Could you retry?

Xanewok · 2019-02-03T13:59:44Z

@bors retry

bors · 2019-02-03T16:07:01Z

⌛ Testing commit 73c39bb with merge e858c26...

submodule: update clippy from 6ce78d1 to 3bda548 rust-lang/rust-clippy@6ce78d1...3bda548 Rustup: unused trim result Auto merge of #3727 - phansch:rustup_unused_trim, r=matthiaskrgr … Travis: Don't run integration tests on every PR commit … Auto merge of #3726 - phansch:some_renaming, r=oli-obk … Fix ICE in vec_box lint and add run-rustfix … Make vec_box MachineApplicable Remove conditionals from base builds … Adding lint for too many lines. Updating number of lines for the failing test to be > 100. … Running util/dev to update README/CHANGELOG Reworking function logic, and adding doc example. … Moving tests to ui-toml to make use of clippy.toml rustfmt Adding back tests, but also reducing threshold by 1 Updating to just warn for one test. Fix test broken by removing comment. Skipping check if in external macro. Adding lint for too many lines. Updating number of lines for the failing test to be > 100. … Moving tests to ui-toml to make use of clippy.toml rustfmt Adding back tests, but also reducing threshold by 1 Updating to just warn for one test. Fix test broken by removing comment. Changing single character string to a character match. Updated readme. Updating code to ignore rustfmt issue. phansch and avborhanian Update clippy_lints/src/types.rs … Update clippy_lints/src/types.rs … Auto merge of #3732 - phansch:fix_ice_3720, r=oli-obk … Auto merge of #3731 - phansch:travis, r=phansch … Auto merge of #2857 - avborhanian:master, r=phansch … Fix breakage due to #58079 … Auto merge of #3736 - mikerite:fix-build-20190203, r=phansch … related with: #58024

bors · 2019-02-03T18:40:18Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Xanewok
Pushing e858c26 to master...

rust-highfive · 2019-02-03T18:41:15Z

📣 Toolstate changed by #58093!

Tested on commit e858c26.
Direct link to PR: #58093

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).

@Manishearth

Tested on commit rust-lang/rust@e858c26. Direct link to PR: <rust-lang/rust#58093> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).

submodule: update clippy from6ce78d1to 3bda548
73c39bb

rust-highfive assigned nikomatsakis Feb 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019

h-michael mentioned this pull request Feb 3, 2019
Update clippy_lint to 3bda548 rust-lang/rls#1287
Merged

rust-highfive assigned oli-obk and unassigned nikomatsakis Feb 3, 2019

h-michael mentioned this pull request Feb 3, 2019
submodule: update rls from c9d25b to f331ff7 #58024
Merged

rust-highfive unassigned oli-obk Feb 3, 2019

rust-highfive assigned Xanewok Feb 3, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2019

bors merged commit 73c39bb into rust-lang:masterFeb 3, 2019

h-michael deleted the clippy branch February 3, 2019 21:39

Uh oh!

Uh oh!

Conversation

h-michael commented Feb 3, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 3, 2019

Uh oh!

rust-highfive commented Feb 3, 2019

Uh oh!

h-michael commented Feb 3, 2019

Uh oh!

Xanewok commented Feb 3, 2019

Uh oh!

h-michael commented Feb 3, 2019

Uh oh!

Xanewok commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

h-michael commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

h-michael commented Feb 3, 2019

Uh oh!

Xanewok commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

bors commented Feb 3, 2019

Uh oh!

rust-highfive commented Feb 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

h-michael commented Feb 3, 2019•
edited
Loading