Uh oh!
There was an error while loading. Please reload this page.
Add Cargo.lock automatically adding message - #58157
Merged
Merged
Conversation
taiki-e
commented
Feb 4, 2019
Member
Also, if you execute |
h-michael
commented
Feb 4, 2019
ContributorAuthor
Yes, I can exclude Cargo.lock before commit. |
Centril
commented
Feb 6, 2019
Contributor
ehuss
commented
Feb 6, 2019
Contributor
fwiw, this needs to be done eventually (once stage0 is 1.34), and it should be safe to do now. Stable Cargo preserves the comment. |
alexcrichton
commented
Feb 7, 2019
Member
@bors: r+ |
bors
commented
Feb 7, 2019
Collaborator
📌 Commit bd4df0c has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Feb 8, 2019
Add Cargo.lock automatically adding message If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099 r? @Centril
emilyalbini added a commit
to emilyalbini/rust
that referenced
this pull request
Feb 10, 2019
Add Cargo.lock automatically adding message If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099 r? @Centril
RalfJung
commented
Feb 10, 2019
Member
@bors rollup |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 10, 2019
Add Cargo.lock automatically adding message If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099 r? @Centril
bors added a commit
that referenced
this pull request
Feb 10, 2019
Rollup of 16 pull requests Successful merges: - #57259 (Update reference of rlibc crate to compiler-builtins crate) - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets) - #57926 (Tiny expansion to docs for `core::convert`.) - #58157 (Add Cargo.lock automatically adding message) - #58203 (rustdoc: display sugared return types for async functions) - #58243 (Add trait alias support in rustdoc) - #58262 (Add #[must_use] message to Fn* traits) - #58295 (std::sys::unix::stdio: explain why we do into_raw) - #58297 (Cleanup JS a bit) - #58317 (Some writing improvement, conciseness of intro) - #58324 (miri: give non-generic functions a stable address) - #58332 (operand-to-place copies should never be overlapping) - #58345 (When there are multiple filenames, print what got interpreted as filenames) - #58346 (rpath computation: explain why we pop()) - #58350 (Fix failing tidy (line endings on Windows)) - #58352 (miri value visitor: use `?` in macro) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I execute
cargo +nightly fix, this change always occurs; cc #58099r? @Centril