Skip to content

Add EmbeddedBook to test list in bootstrap - #58339

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:embedded-book
Feb 10, 2019
Merged

Add EmbeddedBook to test list in bootstrap#58339
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:embedded-book

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Feb 10, 2019

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019
@Mark-Simulacrum

Mark-Simulacrum commented Feb 10, 2019

Copy link
Copy Markdown
MemberAuthor

@bors r+ p=5

@bors

bors commented Feb 10, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 80942e9 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2019
@bors

bors commented Feb 10, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 80942e9 with merge 2e08bb1...

bors added a commit that referenced this pull request Feb 10, 2019
@bors
Auto merge of#58339- Mark-Simulacrum:embedded-book, r=Mark-Simulacrum
2e08bb1
Add EmbeddedBook to test list in bootstrap
r? @alexcrichton
@bors

bors commented Feb 10, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 2e08bb1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Feb 10, 2019
@bors
bors merged commit 80942e9 into rust-lang:masterFeb 10, 2019
@rust-highfive

rust-highfive commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #58339!

Tested on commit 2e08bb1.
Direct link to PR: #58339

💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 10, 2019
@rust-highfive
📣 Toolstate changed byrust-lang/rust#58339!
10c8bb5
Tested on commit rust-lang/rust@2e08bb1.
Direct link to PR: <rust-lang/rust#58339>
💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth@llogiq@mcarton@oli-obk, @rust-lang/infra).
💔 rls on windows: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra).
💔 rls on linux: test-pass → build-fail (cc @nrc@Xanewok, @rust-lang/infra).
@oli-obk

oli-obk commented Feb 10, 2019

Copy link
Copy Markdown
Contributor

how did this PR break clippy!?

@rust-lang/infra any ideas

@phansch

phansch commented Feb 10, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

I think the bot commented on the wrong PR here?

The build log says:

[01:19:05] �[0m�[1m�[38;5;9merror[E0004]�[0m�[0m�[1m: non-exhaustive patterns: `ConstParam(_)` not covered

which was introduced in #58191. But that PR doesn't have a toolstate comment.

@Mark-Simulacrum

Mark-Simulacrum commented Feb 10, 2019

Copy link
Copy Markdown
MemberAuthor

This PR made toolstate work (do anything) after it broke when the embedded book was first added

@Mark-Simulacrum
Mark-Simulacrum deleted the embedded-book branch June 8, 2019 13:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mark-Simulacrum@bors@rust-highfive@oli-obk@phansch@alexcrichton