Skip to content

Revert removed #![feature(nll)] - #58342

Merged
bors merged 1 commit into
rust-lang:masterfrom
taiki-e:nll
Feb 12, 2019
Merged

Revert removed #![feature(nll)]#58342
bors merged 1 commit into
rust-lang:masterfrom
taiki-e:nll

Conversation

@taiki-e

Copy link
Copy Markdown
Member

In PRs related to #58099, #![feature(nll)] was removed from several crates.
This PR reverts it.

Related: #58265 (comment)

cc @Centril

r? @matthewjasper

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 10, 2019
@petrochenkov

Copy link
Copy Markdown
Contributor

Weird.
I thought feature(nll) is enabled fully and unconditionally on 2018 edition.
Why isn't that the case?

@RalfJung

Copy link
Copy Markdown
Member

AFAIK feature(nll) enables "full NLL" while on 2018, we are currently running "migration mode NLL". Also see #57895.

@matthewjasper

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Feb 10, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 2be0993 has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2019
Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
Revert removed #![feature(nll)]
In PRs related to rust-lang#58099, `#![feature(nll)]` was removed from several crates.
This PR reverts it.
Related: rust-lang#58265 (comment)
cc @Centril
r? @matthewjasper
@CentrilCentril mentioned this pull request Feb 12, 2019
bors added a commit that referenced this pull request Feb 12, 2019
Rollup of 11 pull requests
Successful merges:
- #58105 (libarena => 2018)
- #58111 (libterm => 2018)
- #58287 (rustc-std-workspace-core => 2018)
- #58288 (rustc-workspace-hack => 2018)
- #58300 (librustc_typeck => 2018)
- #58313 (Use `?` in librustc macros)
- #58318 (libserialize => 2018)
- #58322 (librustc_codegen_ssa => 2018)
- #58342 (Revert removed #![feature(nll)])
- #58367 (Remove two dead functions.)
- #58382 (docs: remove "experimental" wording from std::os::unix)
Failed merges:
r? @ghost
@bors
bors merged commit 2be0993 into rust-lang:masterFeb 12, 2019
@taiki-e
taiki-e deleted the nll branch February 12, 2019 08:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@taiki-e@petrochenkov@RalfJung@matthewjasper@bors@rust-highfive