Skip to content

Fix tables display - #58384

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-table-display
Feb 20, 2019
Merged

Fix tables display#58384
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:fix-table-display

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Feb 11, 2019

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2019
@tesuji

tesuji commented Feb 12, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

If the fix is in dark.css and light.css, I downloaded these patched files and placed it in target/doc.
Then I disabled the browser cache and reloaded the doc, nothing has changed on my side.

@GuillaumeGomez

GuillaumeGomez commented Feb 12, 2019

Copy link
Copy Markdown
MemberAuthor

Strange, I can't get to reproduce your bug with those changes... Also, when you're switching theme, if overwrites the css, so maybe try to build docs locally?

@tesuji

tesuji commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

I zipped and uploaded the doc. You could try to view it in Firefox. One table is in gokien::tone::Tone enum.

Hope that help!

@GuillaumeGomez

GuillaumeGomez commented Feb 12, 2019

Copy link
Copy Markdown
MemberAuthor

Thanks a lot! Let's check what's going on. :3

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

First results: chrome works fine so maybe a firefox bug. Trying to find a workaround.

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

@lzutao Try again.

@tesuji

tesuji commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

@GuillaumeGomez Before
image

After
image

The settings button is in the search box now.

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

Try again bis.

@tesuji

tesuji commented Feb 15, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Seems to fix the issue. But the font SourceSerifPro-Regular cannot be used, current font is Times New Roman. In the past I could bypass this error by going to the settings page then jump to crate doc on the left side menu.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at file:///stor/github.com/lzutao/rust/gokien/target/doc/SourceSerifPro-Regular.ttf.woff. (Reason: CORS request not http).[Learn More]

image

Edit: Add changed picture:
image

@tesuji

tesuji commented Feb 15, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@GuillaumeGomez Those Traits Implementations section is disappear now. 😢
image

Edit: Add before changed image
image

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

Seems to fix the issue. But the font SourceSerifPro-Regular cannot be used, current font is Times New Roman. In the pass I could bypass this error by going to the settings page then jump to crate doc on the left side menu.

That is another issue. I'm thinking about an invalid path. To be determined...

@GuillaumeGomez Those Traits Implementations section is disappear now. cry

That one, however, is very weird...

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

Can you update your rustdoc version and regenerate the doc then update the CSS and tell me if everything's fine.

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

(and please use nightly rustdoc for the current test)

@tesuji

tesuji commented Feb 15, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

@GuillaumeGomez
Without the patch, latest nightly rustdoc seems to fix the missing side border issue. However, the missing cell issue still exists.
image

After your patch
image

@GuillaumeGomez

GuillaumeGomez commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

Missing cell is "expected" so I guess it's fine.

ping @QuietMisdreavus

QuietMisdreavus
QuietMisdreavus reviewed Feb 18, 2019
View reviewed changes
Comment threadsrc/librustdoc/html/static/themes/light.css Outdated

@QuietMisdreavusQuietMisdreavusFeb 18, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This color in the light theme got changed from #ddd to #000. Was that intentional?

@GuillaumeGomezGuillaumeGomezFeb 19, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it wasn't, good catch!

@GuillaumeGomez

GuillaumeGomez commented Feb 19, 2019

Copy link
Copy Markdown
MemberAuthor

Updated.!

QuietMisdreavus
QuietMisdreavus approved these changes Feb 19, 2019
View reviewed changes

@QuietMisdreavusQuietMisdreavus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@QuietMisdreavus

QuietMisdreavus commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit b53305d has been approved by QuietMisdreavus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2019
@kennytmkennytm mentioned this pull request Feb 19, 2019
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 20, 2019
@kennytm
Rollup merge ofrust-lang#58384- GuillaumeGomez:fix-table-display, r…
07b6d17
…=QuietMisdreavus
Fix tables display
Fixesrust-lang#58134.
cc @lzutao
r? @QuietMisdreavus
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of#58578- kennytm:rollup, r=kennytm
ff5dc27
Rollup of 24 pull requests
Successful merges:
- #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
- #58044 (Make overflowing and wrapping negation const)
- #58303 (Improve stability tags display)
- #58336 (Fix search results interactions)
- #58384 (Fix tables display)
- #58392 (Use less explicit shifting in std::net::ip)
- #58409 (rustdoc: respect alternate flag when formatting impl trait)
- #58456 (Remove no longer accurate diagnostic code about NLL)
- #58528 (Don't use an allocation for ItemId in StmtKind)
- #58530 (Monomorphize less code in fs::{read|write})
- #58534 (Mention capping forbid lints)
- #58536 (Remove UB in pointer tests)
- #58538 (Add missing fmt structs examples)
- #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
- #58544 (Fix doc for rustc "-g" flag)
- #58545 (Add regression test for a specialization-related ICE (#39448))
- #58546 (librustc_codegen_llvm => 2018)
- #58551 (Explain a panic in test case net::tcp::tests::double_bind)
- #58553 (Use more impl header lifetime elision)
- #58562 (Fix style nits)
- #58565 (Fix typo in std::future::Future docs)
- #58568 (Fix a transposition in driver.rs.)
- #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
- #58576 (Stabilize iter::successors and iter::from_fn)
bors added a commit that referenced this pull request Feb 20, 2019
@bors
Auto merge of#58578- kennytm:rollup, r=kennytm
f66e469
Rollup of 24 pull requests
Successful merges:
- #56470 (Modify doctest's auto-`fn main()` to allow `Result`s)
- #58044 (Make overflowing and wrapping negation const)
- #58303 (Improve stability tags display)
- #58336 (Fix search results interactions)
- #58384 (Fix tables display)
- #58392 (Use less explicit shifting in std::net::ip)
- #58409 (rustdoc: respect alternate flag when formatting impl trait)
- #58456 (Remove no longer accurate diagnostic code about NLL)
- #58528 (Don't use an allocation for ItemId in StmtKind)
- #58530 (Monomorphize less code in fs::{read|write})
- #58534 (Mention capping forbid lints)
- #58536 (Remove UB in pointer tests)
- #58538 (Add missing fmt structs examples)
- #58539 (Add alias methods to PathBuf for underlying OsString (#58234))
- #58544 (Fix doc for rustc "-g" flag)
- #58545 (Add regression test for a specialization-related ICE (#39448))
- #58546 (librustc_codegen_llvm => 2018)
- #58551 (Explain a panic in test case net::tcp::tests::double_bind)
- #58553 (Use more impl header lifetime elision)
- #58562 (Fix style nits)
- #58565 (Fix typo in std::future::Future docs)
- #58568 (Fix a transposition in driver.rs.)
- #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`)
- #58576 (Stabilize iter::successors and iter::from_fn)
@bors
bors merged commit b53305d into rust-lang:masterFeb 20, 2019
@GuillaumeGomez
GuillaumeGomez deleted the fix-table-display branch February 20, 2019 17:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@QuietMisdreavusQuietMisdreavusQuietMisdreavus approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@tesuji@QuietMisdreavus@bors@rust-highfive