Add riscv64{imac,gc}-unknown-none-elf targets by Disasm · Pull Request #58406 · rust-lang/rust

Disasm · 2019-02-12T17:27:27Z

rust-highfive · 2019-02-12T17:27:31Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-02-12T17:27:32Z

⚠️Warning⚠️

These commits modify submodules.

davidlt · 2019-02-12T18:08:31Z

Silly question, would this allow me building Rust on riscv64 host, or does it only enable riscv64 (rv64gc) as a target where host is, e.g., x86_64?

jethrogb · 2019-02-12T18:11:10Z

@davidlt No, for that you'd need to add a riscv64gc-unknown-linux-gnu target.

jethrogb · 2019-02-12T18:18:37Z

Please also file a PR against https://github.com/rust-lang/rust-forge/ for https://forge.rust-lang.org/platform-support.html

Disasm · 2019-02-12T18:25:28Z

@jethrogb Thanks for pointing out!

nagisa · 2019-02-12T21:15:58Z

@bors r+

LGTM

bors · 2019-02-12T21:15:59Z

📌 Commit 1f1a824 has been approved by nagisa

Centril · 2019-02-13T14:11:48Z

In-between-rollups-filler, @bors p=1

bors · 2019-02-14T01:20:11Z

⌛ Testing commit 1f1a824 with merge 497254eb99e1e9a3f43538be5bd927938e950c3f...

bors · 2019-02-14T04:22:31Z

💔 Test failed - checks-travis

rust-highfive · 2019-02-14T04:22:33Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:58:47] [RUSTC-TIMING] string_cache test:false 1.256
[02:58:50] [RUSTC-TIMING] elasticlunr test:false 10.059
[02:59:01] [RUSTC-TIMING] markup5ever test:false 5.881
[02:59:03] [RUSTC-TIMING] handlebars test:false 16.610
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-02-14T04:24:01Z

@bors retry

bors · 2019-02-14T17:36:24Z

⌛ Testing commit 1f1a824 with merge 98fc271...

@fintelia

Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

Disasm · 2019-02-14T20:39:05Z

Almost done...

kennytm · 2019-02-15T02:22:07Z

@bors retry

bors · 2019-02-15T06:12:19Z

⌛ Testing commit 1f1a824 with merge 2c5c298...

@fintelia

Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

bors · 2019-02-15T09:13:39Z

💔 Test failed - checks-travis

rust-highfive · 2019-02-15T09:13:40Z

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:03:48] Memory: 8 GB
[00:03:48] Boot ROM Version: VMW71.00V.7581552.B64.1801142334
[00:03:48] Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:48] SMC Version (system): 2.8f0
[00:03:48] Serial Number (system): VMD/wmWgYGMy
[00:03:48] [00:03:48] hw.ncpu: 4
[00:03:48] hw.byteorder: 1234
[00:03:48] hw.memsize: 8589934592
---
[02:50:33] pkgbuild: Adding top-level postinstall script
[02:50:33] pkgbuild: Wrote package to /Users/travis/build/rust-lang/rust/build/tmp/dist/pkg/rustc.pkg
[02:50:34] pkgbuild: Adding top-level postinstall script
[02:50:34] pkgbuild: Wrote package to /Users/travis/build/rust-lang/rust/build/tmp/dist/pkg/cargo.pkg
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-02-15T15:17:02Z

@bors retry

fintelia · 2019-02-15T16:13:54Z

Are all of these timeouts really spurious? And if so, is there any way to raise the time limit slightly? This will be the fourth time testing the same changes...

bors · 2019-02-15T16:20:21Z

⌛ Testing commit 1f1a824 with merge a9410cd...

@fintelia

Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

bors · 2019-02-15T19:05:33Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing a9410cd to master...

rust-highfive · 2019-02-15T19:06:39Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services
travis_fold:start:git.checkout
travis_time:start:0c66cf34
$ git clone --depth=2 --branch=master https://github.com/rust-lang/rust.git rust-lang/rust
---
fi
travis_time:end:03eb835e:start=1550257596557322948,finish=1550257596561747618,duration=4424670
travis_fold:end:before_script.3
travis_time:start:0bd2db50
$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";
Traceback (most recent call last):
Traceback (most recent call last):
File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 196, in <module>
cur_datetime
File "/home/travis/build/rust-lang/rust/src/tools/publish_toolstate.py", line 143, in update_latest
except IOError as (errno, strerror):
ValueError: need more than 0 values to unpack

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Pkgsrc changes: * Bump required rust version to build to 1.33.0. * Adapt patches to changed file locations. * (I worry about 32-bit ports, now that Atomic64 apparently is First-Class; this has been built on NetBSD/amd64 so far) Upstream changes: Version 1.34.0 (2019-04-11) ========================== Language -------- - [You can now use `#[deprecated = "reason"]`][58166] as a shorthand for `#[deprecated(note = "reason")]`. This was previously allowed by mistake but had no effect. - [You can now accept token streams in `#[attr()]`,`#[attr[]]`, and `#[attr{}]` procedural macros.][57367] - [You can now write `extern crate self as foo;`][57407] to import your crate's root into the extern prelude. Compiler -------- - [You can now target `riscv64imac-unknown-none-elf` and `riscv64gc-unknown-none-elf`.][58406] - [You can now enable linker plugin LTO optimisations with `-C linker-plugin-lto`.][58057] This allows rustc to compile your Rust code into LLVM bitcode allowing LLVM to perform LTO optimisations across C/C++ FFI boundaries. - [You can now target `powerpc64-unknown-freebsd`.][57809] Libraries --------- - [The trait bounds have been removed on some of `HashMap<K, V, S>`'s and `HashSet<T, S>`'s basic methods.][58370] Most notably you no longer require the `Hash` trait to create an iterator. - [The `Ord` trait bounds have been removed on some of `BinaryHeap<T>`'s basic methods.][58421] Most notably you no longer require the `Ord` trait to create an iterator. - [The methods `overflowing_neg` and `wrapping_neg` are now `const` functions for all numeric types.][58044] - [Indexing a `str` is now generic over all types that implement `SliceIndex<str>`.][57604] - [`str::trim`, `str::trim_matches`, `str::trim_{start, end}`, and `str::trim_{start, end}_matches` are now `#[must_use]`][57106] and will produce a warning if their returning type is unused. - [The methods `checked_pow`, `saturating_pow`, `wrapping_pow`, and `overflowing_pow` are now available for all numeric types.][57873] These are equivalvent to methods such as `wrapping_add` for the `pow` operation. Stabilized APIs --------------- #### std & core * [`Any::type_id`] * [`Error::type_id`] * [`atomic::AtomicI16`] * [`atomic::AtomicI32`] * [`atomic::AtomicI64`] * [`atomic::AtomicI8`] * [`atomic::AtomicU16`] * [`atomic::AtomicU32`] * [`atomic::AtomicU64`] * [`atomic::AtomicU8`] * [`convert::Infallible`] * [`convert::TryFrom`] * [`convert::TryInto`] * [`iter::from_fn`] * [`iter::successors`] * [`num::NonZeroI128`] * [`num::NonZeroI16`] * [`num::NonZeroI32`] * [`num::NonZeroI64`] * [`num::NonZeroI8`] * [`num::NonZeroIsize`] * [`slice::sort_by_cached_key`] * [`str::escape_debug`] * [`str::escape_default`] * [`str::escape_unicode`] * [`str::split_ascii_whitespace`] #### std * [`Instant::checked_add`] * [`Instant::checked_sub`] * [`SystemTime::checked_add`] * [`SystemTime::checked_sub`] Cargo ----- - [You can now use alternative registries to crates.io.][cargo/6654] Misc ---- - [You can now use the `?` operator in your documentation tests without manually adding `fn main() -> Result<(), _> {}`.][56470] Compatibility Notes ------------------- - [`Command::before_exec` is now deprecated in favor of the unsafe method `Command::pre_exec`.][58059] - [Use of `ATOMIC_{BOOL, ISIZE, USIZE}_INIT` is now deprecated.][57425] As you can now use `const` functions in `static` variables. [58370]: rust-lang/rust#58370 [58406]: rust-lang/rust#58406 [58421]: rust-lang/rust#58421 [58166]: rust-lang/rust#58166 [58044]: rust-lang/rust#58044 [58057]: rust-lang/rust#58057 [58059]: rust-lang/rust#58059 [57809]: rust-lang/rust#57809 [57873]: rust-lang/rust#57873 [57604]: rust-lang/rust#57604 [57367]: rust-lang/rust#57367 [57407]: rust-lang/rust#57407 [57425]: rust-lang/rust#57425 [57106]: rust-lang/rust#57106 [56470]: rust-lang/rust#56470 [cargo/6654]: rust-lang/cargo#6654 [`Any::type_id`]: https://doc.rust-lang.org/std/any/trait.Any.html#tymethod.type_id [`Error::type_id`]: https://doc.rust-lang.org/std/error/trait.Error.html#tymethod.type_id [`atomic::AtomicI16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI16.html [`atomic::AtomicI32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI32.html [`atomic::AtomicI64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI64.html [`atomic::AtomicI8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicI8.html [`atomic::AtomicU16`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU16.html [`atomic::AtomicU32`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU32.html [`atomic::AtomicU64`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU64.html [`atomic::AtomicU8`]: https://doc.rust-lang.org/std/atomic/struct.AtomicU8.html [`convert::Infallible`]: https://doc.rust-lang.org/std/convert/enum.Infallible.html [`convert::TryFrom`]: https://doc.rust-lang.org/std/convert/trait.TryFrom.html [`convert::TryInto`]: https://doc.rust-lang.org/std/convert/trait.TryInto.html [`iter::from_fn`]: https://doc.rust-lang.org/std/iter/fn.from_fn.html [`iter::successors`]: https://doc.rust-lang.org/std/iter/fn.successors.html [`num::NonZeroI128`]: https://doc.rust-lang.org/std/num/struct.NonZeroI128.html [`num::NonZeroI16`]: https://doc.rust-lang.org/std/num/struct.NonZeroI16.html [`num::NonZeroI32`]: https://doc.rust-lang.org/std/num/struct.NonZeroI32.html [`num::NonZeroI64`]: https://doc.rust-lang.org/std/num/struct.NonZeroI64.html [`num::NonZeroI8`]: https://doc.rust-lang.org/std/num/struct.NonZeroI8.html [`num::NonZeroIsize`]: https://doc.rust-lang.org/std/num/struct.NonZeroIsize.html [`slice::sort_by_cached_key`]: https://doc.rust-lang.org/std/slice/fn.sort_by_cached_key [`str::escape_debug`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_debug [`str::escape_default`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_default [`str::escape_unicode`]: https://doc.rust-lang.org/std/primitive.str.html#method.escape_unicode [`str::split_ascii_whitespace`]: https://doc.rust-lang.org/std/primitive.str.html#method.split_ascii_whitespace [`Instant::checked_add`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_add [`Instant::checked_sub`]: https://doc.rust-lang.org/std/time/struct.Instant.html#method.checked_sub [`SystemTime::checked_add`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_add [`SystemTime::checked_sub`]: https://doc.rust-lang.org/std/time/struct.SystemTime.html#method.checked_sub

Disasm added 3 commits February 12, 2019 18:58

Update LLVM: apply patches for RISC-V 64-bit support
0f4668a

Add riscv64imac-unknown-none-elf target
06f21a5

Add riscv64gc-unknown-none-elf target
1f1a824

rust-highfive assigned estebank Feb 12, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2019

Disasm mentioned this pull request Feb 12, 2019
Add riscv64imc-unknown-none-elf target #58012
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2019

nagisa added the relnotes Marks issues that should be documented in the release notes of the next release. label Feb 12, 2019

Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 12, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2019

bors added a commit that referenced this pull request Feb 14, 2019
Auto merge of#58406- Disasm:rv64-support, r=nagisa
98fc271
Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 14, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2019

bors added a commit that referenced this pull request Feb 15, 2019
Auto merge of#58406- Disasm:rv64-support, r=nagisa
2c5c298
Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 15, 2019

Disasm mentioned this pull request Feb 15, 2019
RISC-V Team: Decide on 2019 objectives rust-embedded/wg#276
Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2019

bors added a commit that referenced this pull request Feb 15, 2019
Auto merge of#58406- Disasm:rv64-support, r=nagisa
a9410cd
Add riscv64{imac,gc}-unknown-none-elf targets Previous attempt by @fintelia: #58012 Related: rust-embedded/wg#218

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 15, 2019

bors merged commit 1f1a824 into rust-lang:masterFeb 15, 2019

bors mentioned this pull request Feb 15, 2019
rustc: Update LLVM, remove dead wasm code #58408
Merged

Centril added this to the 1.34 milestone Apr 26, 2019

davidtwco mentioned this pull request Sep 20, 2023
target tier policy compliance #116004
Closed

Uh oh!

Uh oh!

Conversation

Disasm commented Feb 12, 2019

Uh oh!

rust-highfive commented Feb 12, 2019

Uh oh!

rust-highfive commented Feb 12, 2019

Uh oh!

davidlt commented Feb 12, 2019

Uh oh!

jethrogb commented Feb 12, 2019

Uh oh!

jethrogb commented Feb 12, 2019

Uh oh!

Disasm commented Feb 12, 2019

Uh oh!

nagisa commented Feb 12, 2019

Uh oh!

bors commented Feb 12, 2019

Uh oh!

Centril commented Feb 13, 2019

Uh oh!

bors commented Feb 14, 2019

Uh oh!

bors commented Feb 14, 2019

Uh oh!

rust-highfive commented Feb 14, 2019

Uh oh!

Centril commented Feb 14, 2019

Uh oh!

bors commented Feb 14, 2019

Uh oh!

Disasm commented Feb 14, 2019

Uh oh!

kennytm commented Feb 15, 2019

Uh oh!

bors commented Feb 15, 2019

Uh oh!

bors commented Feb 15, 2019

Uh oh!

rust-highfive commented Feb 15, 2019

Uh oh!

kennytm commented Feb 15, 2019

Uh oh!

fintelia commented Feb 15, 2019

Uh oh!

bors commented Feb 15, 2019

Uh oh!

bors commented Feb 15, 2019

Uh oh!

rust-highfive commented Feb 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants