Uh oh!
There was an error while loading. Please reload this page.
specify "upper camel case" in style lint - #58407
Merged
Merged
Conversation
rust-highfive
commented
Feb 12, 2019
Contributor
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
euclioforce-pushed
the
upper-camel-case
branch
from
February 12, 2019 22:16
d5e6fab to
7fb3a98Compareestebank
approved these changes
Feb 13, 2019
estebank
left a comment
Contributor
There was a problem hiding this comment.
r=me, leave it to you to address the actionable comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Also, fix an issue where internal upper case letters were converted to lower case.
euclioforce-pushed
the
upper-camel-case
branch
from
February 13, 2019 18:41
7fb3a98 to
2f95299Compareestebank
commented
Feb 13, 2019
Contributor
@bors r+ |
bors
commented
Feb 13, 2019
Collaborator
📌 Commit 2f95299 has been approved by |
Centril added a commit
to Centril/rust
that referenced
this pull request
Feb 14, 2019
specify "upper camel case" in style lint Also, fix an issue where internal upper case letters were converted to lower case. Fixesrust-lang#57319.
bors added a commit
that referenced
this pull request
Feb 14, 2019
Rollup of 7 pull requests Successful merges: - #58309 (Add more profiler events) - #58347 (Closure bounds fixes) - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them) - #58371 (Check user type annotations for range patterns.) - #58378 (rustc: Implement incremental "fat" LTO) - #58407 (specify "upper camel case" in style lint) - #58449 (Notify @topecongiro when the state of rustfmt has changed) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, fix an issue where internal upper case letters were converted to
lower case.
Fixes#57319.