Uh oh!
There was an error while loading. Please reload this page.
Rollup of 18 pull requests - #58637
Closed
Centril wants to merge 49 commits into
Closed
Conversation
This keeps the slice based iteration and updates the iterator state after each slice. It also uses a loop to reduce the amount of code. This uses unsafe code, so some thorough review would be appreciated.
We can now use `?`
Before this commit, if the builtin target was found, but an error happened when instantiating it (e.g. validating the target specification file failed, etc.), then we ignored those errors and proceeded to try to find a `target_triple.json` file, and if that failed, reported that as an error. With this commit, if rustc is supposed to provide the builtin target, and something fails while instantiating it, that error will get properly propagated.
The solution which uses braces to release the borrow before it is moved is only required to satisfy the 2015 edition borrow checker. All other examples give the expected results for both 2015 and 2018 editions.
Miri has been moved to `rust-lang` a couple of days ago.
This helps to avoid merge conflicts when concurrent PRs append features to the end of the list.
…r=Centril Deny the `overflowing_literals` lint for all editions The `overflowing_literals` was made deny by default for the 2018 edition by rust-lang#54507, however I'm not aware of any reason it can't be made deny by default for the 2015 edition as well.
…r=SimonSapin Deprecate the unstable Vec::resize_default As a way to either get additional feedback to stabilize or help move nightly users off it. Tracking issue: rust-lang#41758 (comment) r? @SimonSapin
deprecate before_exec in favor of unsafe pre_exec Fixesrust-lang#39575 As per the [lang team decision](rust-lang#39575 (comment)): > The language team agreed that before_exec should be unsafe, and leaves the details of a transition plan to the libs team. Cc @alexcrichton @rust-lang/libs how would you like to proceed?
override `VecDeque::try_rfold`, also update iterator This keeps the slice based iteration and updates the iterator state after each slice. It also uses a loop to reduce the amount of code. This uses unsafe code, so some thorough review would be appreciated. Cc @RalfJung
…s-surrounding-lifetimes, r=estebank Suggest removing parentheses surrounding lifetimes Fixesrust-lang#57386. r? @estebank
Add a note about 2018e if someone uses `try {` in 2015e
Inspired by rust-lang#58491, where a `try_blocks` example was accidentally run in 2015, which of course produces a bunch of errors.
What's the philosophy about gating for this? The keyword is stably a keyword in 2018, so I haven't gated it for now but am not mentioning what the keyword _does_. Let me know if I should do differently.
Resolvesrust-lang#53672…drAus improve worst-case performance of BTreeSet intersection Major performance boost when comparing tiny and huge sets. Probably with controversial changes and I sure have questions: - Names and places of functions and types - How many comments to write where - Why does rustc tell me to `ref mut` and `ref` matches on the iterator, while the book says ref is old school. - (Why) do I have to write out the clone like that (`#[derive(Clone)]` doesn't work) - Am I allowed to use `#[derive(Debug)]` there at all? - I'd like to test function `are_proportionate_for_intersection` in test_intersection (or another test case next to it) itself, but I think the private function is inaccessible there. liballoc has other test cases not in the tests directory. PS I don't list these questions to start a discussion here, just to inspire reviewers and to remember myself.
remove a bit of dead code [Six years](rust-lang@5dc5efe) seem to be a long enough transition period 🤣
cleanup macro after 2018 transition We can now use `?`
…ruction, r=GuillaumeGomez Dedup a rustdoc diagnostic construction None
…frewsxcv fix small documentation typo Thanks to @stjepang for catching my mistake.
Search for target_triple.json only if builtin target not found Before this commit, if the builtin target was found, but an error happened when instantiating it (e.g. validating the target specification file failed, etc.), then we ignored those errors and proceeded to try to find a `target_triple.json` file, and if that failed, reported that as an error. With this commit, if rustc is supposed to provide the builtin target, and something fails while instantiating it, that error will get properly propagated. r? @oli-obk
… r=alexcrichton Docs: put Future trait into spotlight If a function returns a type that implements `Future`, there should be a small "i" symbol next to it indicating the return type implements an important trait.
…n, r=matthewjasper Fixesrust-lang#58586: Make E0505 erronous example fail for the 2018 edition The original example worked for 2015, but not the 2018 edition of Rust. Borrowing the moved value after ownership is transferred seems required for 2018. [this](rust-lang/rust@rust-lang:f66e469...gurgalex:b2a02c8#diff-4ca866aea4a6efecd732f1975faaad88R1564) line though is correct for 2018, but not for the 2015 edition. Fixrust-lang#58586
Update miri links Miri has been moved to `rust-lang` a couple of days ago.
Make std feature list sorted This helps to avoid merge conflicts when concurrent PRs append features to the end of the list.
Centril
commented
Feb 22, 2019
ContributorAuthor
@bors r+ p=18 |
bors
commented
Feb 22, 2019
Collaborator
📌 Commit 6ce5b28 has been approved by |
bors
commented
Feb 22, 2019
Collaborator
⌛ Testing commit 6ce5b28 with merge 8565614f9922452a7ab899680988f650c9bae682... |
bors
commented
Feb 22, 2019
Collaborator
💔 Test failed - status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
overflowing_literalslint for all editions #55632 (Deny theoverflowing_literalslint for all editions)VecDeque::try_rfold, also update iterator #58064 (overrideVecDeque::try_rfold, also update iterator)try {in 2015e #58555 (Add a note about 2018e if someone usestry {in 2015e)Failed merges:
r? @ghost