Uh oh!
There was an error while loading. Please reload this page.
Allow lang and lib features to share names - #58741
Conversation
rust-highfive
commented
Feb 25, 2019
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
alexreg
commented
Feb 25, 2019
Looks good! @bors r=alexreg |
bors
commented
Feb 25, 2019
📌 Commit 0f6b148 has been approved by |
alexreg
commented
Feb 25, 2019
@bors p=1 (So that this can land ahead of #57760 (comment) when we r+ p=1 that again.) |
bors
commented
Feb 25, 2019
📌 Commit 0f6b148 has been approved by |
Centril
commented
Feb 26, 2019
r? @alexreg |
petrochenkov
commented
Feb 26, 2019
I think I have deja vu. |
bors
commented
Feb 26, 2019
⌛ Testing commit 0f6b148 with merge 4aedbcf6ac902f3c2e395c68fa8f752dd6a13908... |
bors
commented
Feb 26, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Feb 26, 2019
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
varkor
commented
Feb 26, 2019
@bors retry |
varkor
commented
Feb 26, 2019
Interesting. Maybe this sneaked in with more recent refactorings in the last year? Although I haven't seen any regressions relating to this. I'm not sure... |
bors
commented
Feb 26, 2019
⌛ Testing commit 0f6b148 with merge 37ab9096515882ae082629b25091e4a6e750a88e... |
bors
commented
Feb 26, 2019
💔 Test failed - checks-travis |
rust-highfive
commented
Feb 26, 2019
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
alexreg
commented
Feb 26, 2019
@petrochenkov Well, the evidence says otherwise...? |
alexreg
commented
Feb 26, 2019
@bors retry |
bors
commented
Feb 27, 2019
Allow lang and lib features to share names Fixes#58715. I didn't add a test, because there's currently no standard lang test feature and I felt apprehensive about adding a permanently unstable feature. Instead, a shared lang/lib feature will be used in #57760 and will essentially provide an immediately test.
bors
commented
Feb 27, 2019
☀️ Test successful - checks-travis, status-appveyor |
Fixes#58715.
I didn't add a test, because there's currently no standard lang test feature and I felt apprehensive about adding a permanently unstable feature. Instead, a shared lang/lib feature will be used in #57760 and will essentially provide an immediately test.