Add tests for several E-needstest issues by varkor · Pull Request #58743 · rust-lang/rust

varkor · 2019-02-25T23:57:52Z

This PR adds a number of tests for various E-needstest errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise.

Closes#10876.
Closes#26448.
Closes#26577.
Closes#26619.
Closes#27054.
Closes#44127.
Closes#44255.
Closes#55731.
Closes#57781.

rust-highfive · 2019-02-25T23:57:56Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-02-26T01:10:18Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:022db5ee:start=1551139271445597141,finish=1551139346131469005,duration=74685871864
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout
Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:05:51] .................................................................................................... 2600/5431
[01:05:55] .................................................................................................... 2700/5431
[01:05:59] .................................................................................................... 2800/5431
[01:06:03] .................................................................................................... 2900/5431
[01:06:07] .........................F.......................................................................... 3000/5431
[01:06:14] .................................................................................................... 3200/5431
[01:06:18] ...................................................................i................................ 3300/5431
[01:06:21] .................................................................................................... 3400/5431
[01:06:25] ......................................ii...i..ii.................................................... 3500/5431
---
[01:07:37] [01:07:37] ---- [ui] ui/issues/issue-55731.rs stdout ----
[01:07:37] diff of stderr:
[01:07:37] [01:07:37] 4 LL | multi(Map { //~ ERROR implementation of `DistributedIteratorMulti` is not general enough
[01:07:37] 6 |
[01:07:37] 6 |
[01:07:37] - = note: Due to a where-clause on `multi`,
[01:07:37] - = note: `Map<Cloned<&()>, X>` must implement `DistributedIteratorMulti<&'0 ()>`, for any lifetime `'0`
[01:07:37] - = note: but `Map<Cloned<&()>, X>` actually implements `DistributedIteratorMulti<&'1 ()>`, for some specific lifetime `'1`
[01:07:37] + = note: `DistributedIteratorMulti<&'0 ()>` would have to be implemented for the type `Cloned<&()>`, for any lifetime `'0`
[01:07:37] + = note: but `DistributedIteratorMulti<&'1 ()>` is actually implemented for the type `Cloned<&'1 ()>`, for some specific lifetime `'1`
[01:07:37] 11 error: aborting due to previous error
[01:07:37] 12 [01:07:37] [01:07:37] [01:07:37] [01:07:37] The actual stderr differed from the expected stderr.
[01:07:37] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-55731/issue-55731.stderr
[01:07:37] To update references, rerun the tests and pass the `--bless` flag
[01:07:37] To only update this specific test, also pass `--test-args issues/issue-55731.rs`
[01:07:37] error: 1 errors occurred comparing output.
[01:07:37] status: exit code: 1
[01:07:37] status: exit code: 1
[01:07:37] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-55731.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-55731/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-55731/auxiliary" "-A" "unused"
[01:07:37] ------------------------------------------
[01:07:37] [01:07:37] ------------------------------------------
[01:07:37] stderr:
[01:07:37] stderr:
[01:07:37] ------------------------------------------
[01:07:37] {"message":"implementation of `DistributedIteratorMulti` is not general enough","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-55731.rs","byte_start":926,"byte_end":931,"line_start":48,"line_end":48,"column_start":5,"column_end":10,"is_primary":true,"text":[{"text":" multi(Map { //~ ERROR implementation of `DistributedIteratorMulti` is not general enough","highlight_start":5,"highlight_end":10}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`DistributedIteratorMulti<&'0 ()>` would have to be implemented for the type `Cloned<&()>`, for any lifetime `'0`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"but `DistributedIteratorMulti<&'1 ()>` is actually implemented for the type `Cloned<&'1 ()>`, for some specific lifetime `'1`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: implementation of `DistributedIteratorMulti` is not general enough\n --> /checkout/src/test/ui/issues/issue-55731.rs:48:5\n |\nLL | multi(Map { //~ ERROR implementation of `DistributedIteratorMulti` is not general enough\n | ^^^^^\n |\n = note: `DistributedIteratorMulti<&'0 ()>` would have to be implemented for the type `Cloned<&()>`, for any lifetime `'0`\n = note: but `DistributedIteratorMulti<&'1 ()>` is actually implemented for the type `Cloned<&'1 ()>`, for some specific lifetime `'1`\n\n"}
[01:07:37] [01:07:37] ------------------------------------------
[01:07:37] [01:07:37] thread '[ui] ui/issues/issue-55731.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:07:37] [01:07:37] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:07:37] [01:07:37] [01:07:37] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:37] [01:07:37] [01:07:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:37] Build completed unsuccessfully in 0:04:13
[01:07:37] Build completed unsuccessfully in 0:04:13
[01:07:37] make: *** [check] Error 1
[01:07:37] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:063d4519
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Feb 26 01:10:13 UTC 2019
---
travis_time:end:297aea8c:start=1551143415139057416,finish=1551143415144755202,duration=5697786
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02495916
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0adc5f38
travis_time:start:0adc5f38
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:16b2fb5f
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-02-26T15:26:51Z

r=me, but looks like travis is failing?

varkor · 2019-02-26T20:59:41Z

but looks like travis is failing?

A diagnostic had been updated since I last updated master. I've updated the test.

@bors r=alexcrichton

bors · 2019-02-26T20:59:42Z

📌 Commit 5ab5747 has been approved by alexcrichton

…hton Add tests for several E-needstest issues This PR adds a number of tests for various `E-needstest` errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise. Closesrust-lang#10876. Closesrust-lang#22892. Closesrust-lang#26448. Closesrust-lang#26577. Closesrust-lang#26619. Closesrust-lang#27054. Closesrust-lang#28587. Closesrust-lang#44127. Closesrust-lang#44255. Closesrust-lang#55731. Closesrust-lang#57781.

Centril · 2019-02-27T01:41:22Z

Failed in #58763 (comment), @bors r-

varkor · 2019-02-27T23:49:33Z

(The rollup never merged.)

@bors r=alexcrichton

bors · 2019-02-27T23:49:34Z

📌 Commit 70b853d has been approved by alexcrichton

…hton Add tests for several E-needstest issues This PR adds a number of tests for various `E-needstest` errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise. Closesrust-lang#10876. Closesrust-lang#22892. Closesrust-lang#26448. Closesrust-lang#26577. Closesrust-lang#26619. Closesrust-lang#27054. Closesrust-lang#28587. Closesrust-lang#44127. Closesrust-lang#44255. Closesrust-lang#55731. Closesrust-lang#57781.

kennytm · 2019-03-02T09:29:36Z

@bors r-

This PR failed in #58866 (comment) when targeting WASM with error:

Details

[01:04:03] ---- [ui] ui/asm/invalid-inline-asm-2.rs stdout ----
[01:04:03] [01:04:03] error: Error: expected failure status (Some(1)) but received status None.
[01:04:03] status: signal: 6
[01:04:03] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm/invalid-inline-asm-2.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm-2/a.wasm" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm-2/auxiliary" "-A" "unused"
[01:04:03] stdout:
[01:04:03] ------------------------------------------
[01:04:03] [01:04:03] ------------------------------------------
[01:04:03] stderr:
[01:04:03] ------------------------------------------
[01:04:03] rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7671: void llvm::SelectionDAGBuilder::visitInlineAsm(llvm::ImmutableCallSite): Assertion `OpInfo.isIndirect && "Memory output must be indirect operand"' failed.
[01:04:03] [01:04:03] ------------------------------------------
[01:04:03] [01:04:03] thread '[ui] ui/asm/invalid-inline-asm-2.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:04:03] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:04:03] [01:04:03] ---- [ui] ui/asm/invalid-inline-asm.rs stdout ----
[01:04:03] [01:04:03] error: Error: expected failure status (Some(1)) but received status None.
[01:04:03] status: signal: 6
[01:04:03] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm/invalid-inline-asm.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm/a.wasm" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm/auxiliary" "-A" "unused"
[01:04:03] stdout:
[01:04:03] ------------------------------------------
[01:04:03] [01:04:03] ------------------------------------------
[01:04:03] stderr:
[01:04:03] ------------------------------------------
[01:04:03] rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7828: void llvm::SelectionDAGBuilder::visitInlineAsm(llvm::ImmutableCallSite): Assertion `(OpInfo.ConstraintType == TargetLowering::C_RegisterClass || OpInfo.ConstraintType == TargetLowering::C_Register) && "Unknown constraint type!"' failed.
[01:04:03] [01:04:03] ------------------------------------------
[01:04:03]

The two new asm! tests should have // ignore-wasm (and maybe // ignore-emscripten too).

These still fail on some architectures.

varkor · 2019-03-12T19:07:01Z

@bors r=alexcrichton

bors · 2019-03-12T19:07:02Z

📌 Commit 5b3e1be has been approved by alexcrichton

…hton Add tests for several E-needstest issues This PR adds a number of tests for various `E-needstest` errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise. Closesrust-lang#10876. Closesrust-lang#26448. Closesrust-lang#26577. Closesrust-lang#26619. Closesrust-lang#27054. Closesrust-lang#44127. Closesrust-lang#44255. Closesrust-lang#55731. Closesrust-lang#57781.

bors · 2019-03-12T22:15:14Z

⌛ Testing commit 5b3e1be with merge f8860f2...

Add tests for several E-needstest issues This PR adds a number of tests for various `E-needstest` errors. These tend to have been left open for a long time and seem unlikely to be closed otherwise. Closes#10876. Closes#26448. Closes#26577. Closes#26619. Closes#27054. Closes#44127. Closes#44255. Closes#55731. Closes#57781.

bors · 2019-03-13T01:29:05Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing f8860f2 to master...

Centril · 2019-03-13T01:37:08Z

Finally... 🎉

rust-highfive assigned alexcrichton Feb 25, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2019

varkor force-pushed the bulk-needstest-1 branch from 31daefd to a6445f3Compare February 25, 2019 23:59

varkor force-pushed the bulk-needstest-1 branch from a6445f3 to 5ab5747Compare February 26, 2019 20:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2019

Centril mentioned this pull request Feb 27, 2019
Rollup of 18 pull requests #58763
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2019

varkor force-pushed the bulk-needstest-1 branch from 5ab5747 to 70b853dCompare February 27, 2019 23:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2019

emilyalbini mentioned this pull request Mar 1, 2019
Rollup of 11 pull requests #58831
Closed

kennytm mentioned this pull request Mar 2, 2019
Rollup of 14 pull requests #58866
Merged

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2019

varkor added 14 commits March 12, 2019 18:34

Add a test forrust-lang#44127
3f16518

Add a test forrust-lang#44255
ec56d6e

Add a test forrust-lang#46101
776411b

Add a test forrust-lang#55731
b7763af

Add a test forrust-lang#57781
e3297e7

Add a test forrust-lang#22892
295b6fd

Add a test forrust-lang#28587
5917d9f

Add a test forrust-lang#26577
b4b8a6e

Add a test forrust-lang#27054
1dea6e0

Update test for issuerust-lang#55731
4aa5fd0

Ignore WASM on asm tests
216bee4

Remove invalid ASM tests
57c6a0b
These still fail on some architectures.

Add NLL test error output
d17da3a

Remove compiletest comments from tests
5b3e1be

varkor force-pushed the bulk-needstest-1 branch from cfaed80 to 5b3e1beCompare March 12, 2019 19:06

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2019

emilyalbini mentioned this pull request Mar 12, 2019
Rollup of 14 pull requests #59141
Closed

bors mentioned this pull request Mar 12, 2019
rustc: fix ICE when trait alias has bare Self #59118
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 13, 2019

bors merged commit 5b3e1be into rust-lang:masterMar 13, 2019

JohnTitor mentioned this pull request Aug 4, 2019
internal compiler error: unexpected panic for issue #35896 #46101
Closed

matthiaskrgr mentioned this pull request Mar 18, 2024
ICE: can't find an upper bound in nll::compute_regions in rustc_borrowck #122704
Closed

Uh oh!

Uh oh!

Conversation

varkor commented Feb 25, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Feb 25, 2019

Uh oh!

rust-highfive commented Feb 26, 2019

Uh oh!

alexcrichton commented Feb 26, 2019

Uh oh!

varkor commented Feb 26, 2019

Uh oh!

bors commented Feb 26, 2019

Uh oh!

Centril commented Feb 27, 2019

Uh oh!

varkor commented Feb 27, 2019

Uh oh!

bors commented Feb 27, 2019

Uh oh!

kennytm commented Mar 2, 2019

Uh oh!

varkor commented Mar 12, 2019

Uh oh!

bors commented Mar 12, 2019

Uh oh!

bors commented Mar 12, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

Centril commented Mar 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

varkor commented Feb 25, 2019•
edited
Loading