Don't promote function calls to nonpromotable things by oli-obk · Pull Request #58784 · rust-lang/rust

oli-obk · 2019-02-27T16:43:52Z

should we additionally check the function call return type? It might be a promotable function (or any const fn inside a const fn), but its return type might contain interior mutability.

pnkfelix · 2019-02-28T15:38:04Z

discussed at T-compiler meeting. approved for beta backport.

eddyb · 2019-03-01T16:10:28Z

IsNotPromotable should be removed in favor of just IsNotConst, but right now this seems good.

Looks like the reason this regressed is because "not promotable" used to be turned into "not const" but at some point in the refactor I simplified it too much and only preserved "not const" from callee/arguments, but not "not promotable".

r=me with a FIXME about removing IsNotPromotable

oli-obk · 2019-03-01T16:11:41Z

@bors r=eddyb

bors · 2019-03-01T16:11:41Z

📌 Commit 8c16507 has been approved by eddyb

bors · 2019-03-04T07:41:46Z

⌛ Testing commit 8c16507 with merge f40e37747ba74cd7fd974cb092033474d4d8c6f9...

bors · 2019-03-04T10:48:41Z

💔 Test failed - status-appveyor

ljedrz · 2019-03-04T11:22:58Z

The error looks spurious; maybe my try rights are already in force?

@bors retry

bors · 2019-03-04T14:05:15Z

⌛ Testing commit 8c16507 with merge 113a74e1c5bdcf894fd624d1465b342324779fc6...

bors · 2019-03-04T17:10:47Z

💔 Test failed - status-appveyor

oli-obk · 2019-03-05T08:42:05Z

Build completed successfully in 2:58:53
Command exited with code 259

@bors retry (different builder failed that passed in the previous run)

oli-obk · 2019-03-10T08:51:08Z

@bors r=eddyb p=1

bors · 2019-03-10T08:51:09Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Make the rustc driver and interface demand driven #56732

bors · 2019-03-10T08:51:10Z

📌 Commit 8c16507 has been approved by eddyb

bors · 2019-03-10T09:25:04Z

⌛ Testing commit 8c16507 with merge 2d04b00...

@eddyb

Don't promote function calls to nonpromotable things fixes#58767 and fixes#58634 r? @eddyb should we additionally check the function call return type? It might be a promotable function (or any `const fn` inside a `const fn`), but its return type might contain interior mutability.

bors · 2019-03-10T12:26:10Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-10T12:26:12Z

The job i686-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:57:51] travis_fold:start:test_stage2-rustdoc
travis_time:start:test_stage2-rustdoc
Testing rustdoc stage2 (i686-unknown-linux-gnu -> i686-unknown-linux-gnu)
[02:57:51] Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-03-10T12:32:34Z

@bors retry timeout

bors · 2019-03-11T01:28:25Z

⌛ Testing commit 8c16507 with merge c2ddf5a...

@eddyb

Don't promote function calls to nonpromotable things fixes#58767 and fixes#58634 r? @eddyb should we additionally check the function call return type? It might be a promotable function (or any `const fn` inside a `const fn`), but its return type might contain interior mutability.

bors · 2019-03-11T04:25:10Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing c2ddf5a to master...

@ghost

[beta] Rollup backports Cherry-picked: * Include bounds from promoted constants in NLL #57202 * Warning period for detecting nested impl trait #58608 * Don't promote function calls to nonpromotable things #58784 * Make migrate mode work at item level granularity #58788 * Expand where negative supertrait specific error is shown #58861 * Expand where negative supertrait specific error is shown #58861 Rolled up: * [BETA] Update cargo #59217 r? @ghost

@eddyb

Retire `IsNotConst` naming This naming scheme caused a lot of confusion lately (including ICEs) due to misrefactored code. Also clean up the initialization code for said flag. r? @eddyb previous discussions: rust-lang#58784 (comment)rust-lang#58403 (comment)

@eddyb

Retire `IsNotConst` naming This naming scheme caused a lot of confusion lately (including ICEs) due to misrefactored code. Also clean up the initialization code for said flag. r? @eddyb previous discussions: rust-lang#58784 (comment)rust-lang#58403 (comment)

@eddyb

Retire `IsNotConst` naming This naming scheme caused a lot of confusion lately (including ICEs) due to misrefactored code. Also clean up the initialization code for said flag. r? @eddyb previous discussions: rust-lang#58784 (comment)rust-lang#58403 (comment)

@eddyb

Retire `IsNotConst` naming This naming scheme caused a lot of confusion lately (including ICEs) due to misrefactored code. Also clean up the initialization code for said flag. r? @eddyb previous discussions: rust-lang#58784 (comment)rust-lang#58403 (comment)

Don't promote function calls to nonpromotable things
e67050e

rust-highfive assigned eddyb Feb 27, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2019

oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 28, 2019

pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 28, 2019

pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 28, 2019

Schedule the demolition of IsNotPromotable
8c16507

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 4, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2019

oli-obk mentioned this pull request Mar 5, 2019
TyLayout::field_type ICE on 1.34.0-nightly 865cb7010 2019-02-10 #58610
Closed

oli-obk mentioned this pull request Mar 10, 2019
Rustc panic when building bobbin-sdk #58767
Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2019

bors merged commit 8c16507 into rust-lang:masterMar 11, 2019

oli-obk deleted the accidental_promotion branch March 11, 2019 11:45

oli-obk mentioned this pull request Mar 11, 2019
panic with "Layout mismatch when copying!" #58742
Closed

emilyalbini mentioned this pull request Mar 16, 2019
[beta] Rollup backports #59235
Merged

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 16, 2019

lqd mentioned this pull request Mar 25, 2019
ICE on beta and nightly: index out of bounds in RestoreSubsliceArrayMoveOut MIR pass #59048
Closed

oli-obk mentioned this pull request Apr 8, 2019
Retire IsNotConst naming #59796
Merged

Uh oh!

Uh oh!

Conversation

oli-obk commented Feb 27, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pnkfelix commented Feb 28, 2019

Uh oh!

eddyb commented Mar 1, 2019

Uh oh!

oli-obk commented Mar 1, 2019

Uh oh!

bors commented Mar 1, 2019

Uh oh!

bors commented Mar 4, 2019

Uh oh!

bors commented Mar 4, 2019

Uh oh!

ljedrz commented Mar 4, 2019

Uh oh!

bors commented Mar 4, 2019

Uh oh!

bors commented Mar 4, 2019

Uh oh!

oli-obk commented Mar 5, 2019

Uh oh!

oli-obk commented Mar 10, 2019

Uh oh!

bors commented Mar 10, 2019

Uh oh!

bors commented Mar 10, 2019

Uh oh!

bors commented Mar 10, 2019

Uh oh!

bors commented Mar 10, 2019

Uh oh!

rust-highfive commented Mar 10, 2019

Uh oh!

oli-obk commented Mar 10, 2019

Uh oh!

bors commented Mar 11, 2019

Uh oh!

bors commented Mar 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oli-obk commented Feb 27, 2019•
edited
Loading