Uh oh!
There was an error while loading. Please reload this page.
Revert abort on unwinding through FFI on stable - #58795
Merged
Merged
Conversation
rust-highfive
commented
Feb 28, 2019
Contributor
|
Mark-Simulacrum
commented
Feb 28, 2019
MemberAuthor
cc @rust-lang/compiler -- would appreciate a review of this fairly quickly (we need it to land before tomorrow to avoid delaying stable) |
nikomatsakis
approved these changes
Feb 28, 2019
Contributor
There was a problem hiding this comment.
what's up with this? just an orthogonal change?
See rust-lang#58794 for context.
Mark-Simulacrumforce-pushed
the
stable-next
branch
from
February 28, 2019 01:12
bae33e5 to
bd1f032CompareMark-Simulacrum
commented
Feb 28, 2019
MemberAuthor
@bors r+ p=100 |
bors
commented
Feb 28, 2019
Collaborator
📌 Commit bd1f032 has been approved by |
bors
commented
Feb 28, 2019
Collaborator
bors added a commit
that referenced
this pull request
Feb 28, 2019
Revert abort on unwinding through FFI on stable r? @alexcrichton
bors
commented
Feb 28, 2019
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
Feb 28, 2019
MemberAuthor
@bors retry - 259 |
bors
commented
Feb 28, 2019
Collaborator
⌛ Testing commit bd1f032 with merge 6173377c8587a2e4589827aa0163f8322097aca4... |
bors
commented
Feb 28, 2019
Collaborator
💥 Test timed out |
emilyalbini
commented
Feb 28, 2019
Member
macOS is time travelling again. @bors retry |
Centril
commented
Feb 28, 2019
Contributor
@bors retry |
bors
commented
Feb 28, 2019
Collaborator
bors added a commit
that referenced
this pull request
Feb 28, 2019
Revert abort on unwinding through FFI on stable This is entirely done to allow us more time for discussion about what behavior we want to specify here.
bors
commented
Feb 28, 2019
Collaborator
☀️ Test successful - checks-travis, status-appveyor |
| -------- | ||
| - [You can now use the `cfg(target_vendor)` attribute.][57465] E.g. | ||
| `#[cfg(target_vendor="linux")] fn main() { println!("Hello Linux!"); }` | ||
| `#[cfg(target_vendor="apple")] fn main() { println!("Hello Apple!"); }` |
Member
There was a problem hiding this comment.
Looks like more spurious changes? Shouldn't this (have been) fixed before approving...?
MemberAuthor
There was a problem hiding this comment.
This was intentional (note the separate commit); we wanted to land some additional release notes and since we were merging this into stable combined it into one.
In hindsight, I should've mentioned this in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is entirely done to allow us more time for discussion about what behavior we want to specify here.