Skip to content

[WIP] Place unroll -> iterate refactor - #58819

Closed
spastorino wants to merge 4 commits into
rust-lang:masterfrom
spastorino:place2_2
Closed

[WIP] Place unroll -> iterate refactor#58819
spastorino wants to merge 4 commits into
rust-lang:masterfrom
spastorino:place2_2

Conversation

@spastorino

@spastorinospastorino commented Feb 28, 2019

Copy link
Copy Markdown
Member

Do not merge this is work in progress.

r? @oli-obk

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2019
oli-obk
oli-obk reviewed Mar 11, 2019
View reviewed changes
Comment threadsrc/librustc/mir/mod.rs
/// Iterator over components; see `PlaceProjections::iter` for more
/// information.
///
/// N.B., this is not a *true* Rust iterator -- the code above just

@oli-obkoli-obkMar 11, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we could do is make it a real iterator and also implement https://doc.rust-lang.org/std/iter/trait.FusedIterator.html for that iterator. This way we guarantee that after the first None we keep getting Nones.

@oli-obk

oli-obk commented Mar 11, 2019

Copy link
Copy Markdown
Contributor

@spastorino this looks like a good intermediate step that we could merge before any further changes.

@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 18, 2019

Copy link
Copy Markdown

ping from triage @oli-obk any updates?

@oli-obkoli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2019
@spastorino

spastorino commented Mar 19, 2019

Copy link
Copy Markdown
MemberAuthor

@Dylan-DPC I'm the one "working" on this. This is still in WIP, we need to land some stuff before. I'm slowly catching up with stuff but have been very busy.

@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 19, 2019

Copy link
Copy Markdown

thanks. I thought some part of the review was pending. Great :)

@bors

bors commented Mar 26, 2019

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #59433) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril

Centril commented Mar 30, 2019

Copy link
Copy Markdown
Contributor

Ping from triage, @spastorino What other stuff is this blocked on? what PRs if any?

@spastorino

spastorino commented Apr 2, 2019

Copy link
Copy Markdown
MemberAuthor

@Centril blocked on https://rustlatam.org 😂. Now that the thing have finished I'm back to work on Place 2.0

@spastorino

spastorino commented Apr 10, 2019

Copy link
Copy Markdown
MemberAuthor

Going to close this for now and reopen after I change Place to a struct

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obkoli-obkoli-obk left review comments

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@spastorino@oli-obk@Dylan-DPC-zz@bors@Centril@rust-highfive