Skip to content

libstd: deny(elided_lifetimes_in_paths) - #58828

Merged
bors merged 5 commits into
rust-lang:masterfrom
Centril:deny-elided_lifetimes_in_paths-libstd
Mar 31, 2019
Merged

libstd: deny(elided_lifetimes_in_paths)#58828
bors merged 5 commits into
rust-lang:masterfrom
Centril:deny-elided_lifetimes_in_paths-libstd

Conversation

@Centril

@CentrilCentril commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Centrilforce-pushed the deny-elided_lifetimes_in_paths-libstd branch from 1ac0060 to 71842fcCompareMarch 1, 2019 08:59
@oli-obk

oli-obk commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 1, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 71842fcd21836a764c62cca4f271a319b7811e94 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@kennytm

kennytm commented Mar 1, 2019

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2019
@Centril
Centrilforce-pushed the deny-elided_lifetimes_in_paths-libstd branch from 71842fc to ff9173eCompareMarch 1, 2019 11:53
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@Centril
Centrilforce-pushed the deny-elided_lifetimes_in_paths-libstd branch from ff9173e to 2463d75CompareMarch 3, 2019 13:36
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Centrilforce-pushed the deny-elided_lifetimes_in_paths-libstd branch from 2463d75 to 6b1e200CompareMarch 3, 2019 13:49
@CentrilCentril added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2019
@Centril

Centril commented Mar 3, 2019

Copy link
Copy Markdown
ContributorAuthor

@oli-obk Should hopefully be good to go now. :)

@oli-obk

oli-obk commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 4, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 6b1e200 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2019
@bors

bors commented Mar 15, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6b1e200 with merge 547c074...

bors added a commit that referenced this pull request Mar 15, 2019
@bors
Auto merge of#58828- Centril:deny-elided_lifetimes_in_paths-libstd,…
547c074
… r=oli-obk
libstd: deny(elided_lifetimes_in_paths)
r? @oli-obk
@bors

bors commented Mar 16, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Sign in to view
@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2019
@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 13a4ac3 with merge 5d282dbde81d82f25acc4f2578e8867cb888500c...

@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-travis

@rust-highfive

rust-highfive commented Mar 31, 2019

Copy link
Copy Markdown
Contributor

The job dist-various-2 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:16:29] [RUSTC-TIMING] panic_unwind test:false 0.329
[01:16:30] warning: dropping unsupported crate type `dylib` for target `x86_64-fortanix-unknown-sgx`
[01:16:30] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/abi/tls.rs:87:38
[01:16:31] |
[01:16:31] 87 | pub unsafe fn activate(&self) -> ActiveTls {
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/abi/tls.rs:144:31
[01:16:31] |
[01:16:31] 144 | pub fn iter(&self) -> SyncBitsetIter {
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/abi/usercalls/alloc.rs:432:27
[01:16:31] 432 | pub fn iter(&self) -> Iter<T>
[01:16:31] | ^^^^^^^ help: indicate the anonymous lifetime: `Iter<'_, T>`
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/abi/usercalls/alloc.rs:441:35
[01:16:31] |
[01:16:31] 441 | pub fn iter_mut(&mut self) -> IterMut<T>
[01:16:31] | ^^^^^^^^^^ help: indicate the anonymous lifetime: `IterMut<'_, T>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:143:31
[01:16:31] |
[01:16:31] 143 | pub fn wait<T>(mut guard: SpinMutexGuard<WaitVariable<T>>) {
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<T>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:165:37
[01:16:31] |
[01:16:31] 165 | pub fn notify_one<T>(mut guard: SpinMutexGuard<WaitVariable<T>>)
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<T>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:166:19
[01:16:31] |
[01:16:31] 166 | -> Result<WaitGuard<T>, SpinMutexGuard<WaitVariable<T>>>
[01:16:31] | ^^^^^^^^^^^^ help: indicate the anonymous lifetime: `WaitGuard<'_, T>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:166:33
[01:16:31] |
[01:16:31] 166 | -> Result<WaitGuard<T>, SpinMutexGuard<WaitVariable<T>>>
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<T>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:189:37
[01:16:31] |
[01:16:31] 189 | pub fn notify_all<T>(mut guard: SpinMutexGuard<WaitVariable<T>>)
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<T>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:190:19
[01:16:31] |
[01:16:31] 190 | -> Result<WaitGuard<T>, SpinMutexGuard<WaitVariable<T>>>
[01:16:31] | ^^^^^^^^^^^^ help: indicate the anonymous lifetime: `WaitGuard<'_, T>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:190:33
[01:16:31] |
[01:16:31] 190 | -> Result<WaitGuard<T>, SpinMutexGuard<WaitVariable<T>>>
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<T>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:436:31
[01:16:31] |
[01:16:31] 436 | pub fn lock(&self) -> SpinMutexGuard<T> {
[01:16:31] | ^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, T>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/waitqueue.rs:448:42
[01:16:31] |
[01:16:31] 448 | pub fn try_lock(&self) -> Option<SpinMutexGuard<T>> {
[01:16:31] | ^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, T>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/backtrace.rs:35:66
[01:16:31] |
[01:16:31] 35 | unsafe { uw::_Unwind_Backtrace(trace_fn, &mut cx as *mut Context as *mut libc::c_void) };
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/net.rs:51:27
[01:16:31] 51 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
[01:16:31] | ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/net.rs:216:27
[01:16:31] 216 | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
[01:16:31] | ^^^^^^^^^^^^^^- help: indicate the anonymous lifetime: `<'_>`
[01:16:31] [01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/rwlock.rs:96:21
[01:16:31] |
[01:16:31] 96 | mut rguard: SpinMutexGuard<WaitVariable<Option<NonZeroUsize>>>,
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<Option<NonZeroUsize>>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/rwlock.rs:97:17
[01:16:31] |
[01:16:31] 97 | wguard: SpinMutexGuard<WaitVariable<bool>>,
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<bool>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/rwlock.rs:123:17
[01:16:31] |
[01:16:31] 123 | rguard: SpinMutexGuard<WaitVariable<Option<NonZeroUsize>>>,
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<Option<NonZeroUsize>>>`
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] error: hidden lifetime parameters in types are deprecated
[01:16:31] --> src/libstd/sys/sgx/rwlock.rs:124:17
[01:16:31] |
[01:16:31] 124 | wguard: SpinMutexGuard<WaitVariable<bool>>,
[01:16:31] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: indicate the anonymous lifetime: `SpinMutexGuard<'_, WaitVariable<bool>>`
[01:16:36] error: aborting due to 20 previous errors
[01:16:36] [01:16:36] [RUSTC-TIMING] std test:false 6.505
[01:16:36] error: Could not compile `std`.
---
travis_time:end:3a31c89a:start=1554017071916035947,finish=1554017071930895271,duration=14859324
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04f0c4e2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1791f049
travis_time:start:1791f049
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:273a819e
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 31, 2019
@kennytm

kennytm commented Mar 31, 2019

Copy link
Copy Markdown
Member

@bors r-

The SGX target contained hidden lifetime parameters.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2019
@Centril
Centrilforce-pushed the deny-elided_lifetimes_in_paths-libstd branch from 13a4ac3 to 351a20cCompareMarch 31, 2019 10:57
@Centril

Centril commented Mar 31, 2019

Copy link
Copy Markdown
ContributorAuthor

Fixed those... 😓

@bors r=oli-obk

@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 351a20c has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 31, 2019
@CentrilCentril mentioned this pull request Mar 31, 2019
Closed
@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 351a20c with merge 1d435932ef9d6fff7db54a229a1af354f717df57...

@Centril

Centril commented Mar 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors r=oli-obk

@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1d9508a has been approved by oli-obk

@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d9508a with merge c298fe2aec3fab68c45f257c69529784d7772a70...

@CentrilCentril mentioned this pull request Mar 31, 2019
Closed
@Centril

Centril commented Mar 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1d9508a with merge c05d12333fa83d0377766cc938e5ce36025362d5...

@CentrilCentril mentioned this pull request Mar 31, 2019
Merged
@Centril

Centril commented Mar 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@bors retry

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Centril@rust-highfive@oli-obk@bors@kennytm